[Lldb-commits] [lldb] [lldb] Remove ConstString from Breakpoint::GetMatchingFileLine (PR #205210)

[via lldb-commits]

llvmorg-github-actions[bot] wrote:


<!--LLVM PR SUMMARY COMMENT-->

@llvm/pr-subscribers-lldb

Author: Alex Langford (bulbazord)

<details>
<summary>Changes</summary>



---
Full diff: https://github.com/llvm/llvm-project/pull/205210.diff


3 Files Affected:

- (modified) lldb/include/lldb/Breakpoint/Breakpoint.h (+1-1) 
- (modified) lldb/source/Breakpoint/Breakpoint.cpp (+2-1) 
- (modified) lldb/source/Commands/CommandObjectBreakpoint.cpp (+1-1) 


``````````diff
diff --git a/lldb/include/lldb/Breakpoint/Breakpoint.h b/lldb/include/lldb/Breakpoint/Breakpoint.h
index c0bad98c95b29..67a741c6c9251 100644
--- a/lldb/include/lldb/Breakpoint/Breakpoint.h
+++ b/lldb/include/lldb/Breakpoint/Breakpoint.h
@@ -511,7 +511,7 @@ class Breakpoint : public std::enable_shared_from_this<Breakpoint>,
   ///     size is 0 and true is returned, it means the breakpoint fully matches
   ///     the
   ///     description.
-  bool GetMatchingFileLine(ConstString filename, uint32_t line_number,
+  bool GetMatchingFileLine(llvm::StringRef filename, uint32_t line_number,
                            BreakpointLocationCollection &loc_coll);
 
   void GetFilterDescription(Stream *s);
diff --git a/lldb/source/Breakpoint/Breakpoint.cpp b/lldb/source/Breakpoint/Breakpoint.cpp
index 201d8d20c4901..07412cd092f0d 100644
--- a/lldb/source/Breakpoint/Breakpoint.cpp
+++ b/lldb/source/Breakpoint/Breakpoint.cpp
@@ -1064,7 +1064,8 @@ void Breakpoint::GetResolverDescription(Stream *s) {
     m_resolver_sp->GetDescription(s);
 }
 
-bool Breakpoint::GetMatchingFileLine(ConstString filename, uint32_t line_number,
+bool Breakpoint::GetMatchingFileLine(llvm::StringRef filename,
+                                     uint32_t line_number,
                                      BreakpointLocationCollection &loc_coll) {
   // TODO: To be correct, this method needs to fill the breakpoint location
   // collection
diff --git a/lldb/source/Commands/CommandObjectBreakpoint.cpp b/lldb/source/Commands/CommandObjectBreakpoint.cpp
index f11af5fff2362..38b79d6c33922 100644
--- a/lldb/source/Commands/CommandObjectBreakpoint.cpp
+++ b/lldb/source/Commands/CommandObjectBreakpoint.cpp
@@ -2536,7 +2536,7 @@ class CommandObjectBreakpointClear : public CommandObjectParsed {
     switch (break_type) {
     case eClearTypeFileAndLine: // Breakpoint by source position
     {
-      const ConstString filename(m_options.m_filename);
+      llvm::StringRef filename(m_options.m_filename);
       BreakpointLocationCollection loc_coll;
 
       for (size_t i = 0; i < num_breakpoints; ++i) {

``````````

</details>


https://github.com/llvm/llvm-project/pull/205210