[Lldb-commits] [lldb] [lldb] Ignore async notification packets while waiting for a response (PR #202556)
via lldb-commits
lldb-commits at lists.llvm.org
Mon Jun 22 02:52:22 PDT 2026
dlgus8648 wrote:
Thanks for the comparison and for providing the test case!
You are spot on about the multiple notifications.
The core of the original issue was that CheckForPacket() actually does a good job of classifying packets into Standard vs Notify, but the calling code blurred them together by treating anything != Invalid as the final response.
My fix explicitly separates the Notify case and uses a while loop to discard all incoming notifications until the real Standard reply arrives. Because it relies on a loop rather than a single if skip, it inherently handles any number of asynchronous notifications before the actual response.
This explicit loop handling is exactly why this PR has a few more changes compared to the other one.
On the test: the unit tests already include a multi-notification case, and I've also added your API test to this PR and confirmed it passes locally.
(Note: This comment was translated/refined with AI assistance.)
https://github.com/llvm/llvm-project/pull/202556
More information about the lldb-commits
mailing list