[Lldb-commits] [lldb] [lldb] Fix race/timeout in TestInternalThreadSuspension (PR #203202)
Raphael Isemann via lldb-commits
lldb-commits at lists.llvm.org
Tue Jun 16 03:58:59 PDT 2026
https://github.com/Teemperor updated https://github.com/llvm/llvm-project/pull/203202
>From 07ed92041619517f1ab892af929fe7bf3bff9332 Mon Sep 17 00:00:00 2001
From: Raphael Isemann <rise at apple.com>
Date: Wed, 10 Jun 2026 13:21:50 +0100
Subject: [PATCH] [lldb] Fix race/timeout in TestInternalThreadSuspension
This test launches a thread and then waits for a signal from the
launched thread. Below is one possible interleaving, where the
`pthread_cond_signal` (2) wins the race and becomes a no-op while (3)
is locking until the test times out.
```
void *
suspend_func (void *unused) {
[...]
// 2. Created thread reaches this and signals.
pthread_cond_signal(&signal_cond);
[...]
}
int main() {
pthread_mutex_lock(&signal_mutex);
// 1. Thread is created
pthread_create(&suspend_thread, NULL, suspend_func, NULL);
// Enable this to make race reliable:
// sleep(1);
// 3. We start waiting on signal_cond, but 2. already executed.
pthread_cond_wait(&signal_cond, &signal_mutex);
```
This patch guards (2) with signal_mutex so it can only be executed
after pthread_cond_wait unlocks signal_mutex.
---
lldb/test/API/macosx/thread_suspend/main.c | 4 +++-
1 file changed, 3 insertions(+), 1 deletion(-)
diff --git a/lldb/test/API/macosx/thread_suspend/main.c b/lldb/test/API/macosx/thread_suspend/main.c
index 03da7a71505c7..cb4c1f34ae7ff 100644
--- a/lldb/test/API/macosx/thread_suspend/main.c
+++ b/lldb/test/API/macosx/thread_suspend/main.c
@@ -16,7 +16,9 @@ function_to_call() {
void *
suspend_func (void *unused) {
pthread_setname_np("Look for me");
+ pthread_mutex_lock(&signal_mutex);
pthread_cond_signal(&signal_cond);
+ pthread_mutex_unlock(&signal_mutex);
pthread_mutex_lock(&suspend_mutex);
return NULL; // We allowed the suspend thread to run
@@ -41,7 +43,7 @@ main()
pthread_create(&suspend_thread, NULL, suspend_func, NULL);
pthread_cond_wait(&signal_cond, &signal_mutex);
-
+
mach_port_t th_port = pthread_mach_thread_np(suspend_thread);
thread_suspend(th_port);
More information about the lldb-commits
mailing list