[Lldb-commits] [lldb] [lldb] Ignore async notification packets while waiting for a response (PR #202556)

[Felipe de Azevedo Piovezan via lldb-commits]

================
@@ -258,7 +268,16 @@ GDBRemoteCommunication::WaitForPacketNoLock(StringExtractorGDBRemote &packet,
                      error, bytes_read);
 
     if (bytes_read > 0) {
-      if (CheckForPacket(buffer, bytes_read, packet) != PacketType::Invalid)
+      // Drop any async notification packets (see above) and keep waiting for
+      // the actual response.
+      packet_type = CheckForPacket(buffer, bytes_read, packet);
+      while (packet_type == PacketType::Notify) {
+        LLDB_LOGF(log,
+                  "GDBRemoteCommunication::%s ignoring notification packet",
+                  __FUNCTION__);
+        packet_type = CheckForPacket(nullptr, 0, packet);
+      }
----------------
felipepiovezan wrote:

please create a helper function `GetNextNonNotifyPacket`, as this is duplicated code with the loop above.

https://github.com/llvm/llvm-project/pull/202556