[Lldb-commits] [clang] [lldb] [clang] Honor ShowLevel for diagnostics without a source location (PR #203520)

[Yao Qi via lldb-commits]

================
@@ -140,7 +140,7 @@ def test_source_and_caret_printing(self):
             """
     1 | foo(1, 2)
       | ^~~
-note: candidate function not viable: requires single argument 'x', but 2 arguments were provided
+candidate function not viable: requires single argument 'x', but 2 arguments were provided
----------------
qiyao wrote:

Hi @Michael137 , thanks for the review.  This `note:` is from clang's diagnostic, and this PR removes it.  This is the API test, so lldb cli doesn't add its own diagnostic (`note:`).  In CLI, `note:` is still there, and colored.
```
(lldb) expression foo(1,2)
                  ˄
                  ╰─ error: no matching function for call to 'foo'
note: Ran expression as 'C++11'.
note: candidate function not viable: requires single argument 'x', but 2 arguments were provided
```

https://github.com/llvm/llvm-project/pull/203520