[Lldb-commits] [lldb] [LLDB] RISCV feature attribute support and allows overriding additional(default) feature (PR #147990)

[Nico Weber via lldb-commits]

================
@@ -42,6 +42,7 @@ config.lldb_use_lldb_server = @LLDB_TEST_USE_LLDB_SERVER@
 config.lldb_module_cache = os.path.join("@LLDB_TEST_MODULE_CACHE_LLDB@", "lldb-shell")
 config.clang_module_cache = os.path.join("@LLDB_TEST_MODULE_CACHE_CLANG@", "lldb-shell")
 config.clang_resource_dir = os.path.join("@CLANG_RESOURCE_DIR@")
+config.targets_to_build = "@LLVM_TARGETS_TO_BUILD@"
----------------
nico wrote:

llvm/test/lit.site.cfg.py.in uses TARGETS_TO_BUILD, and llvm/test/lit.cfg.py just calls split() on that.

I suppose lldb can't use TARGETS_TO_BUILD since it's in a different project (?), but should we change llvm to be consistent with this here? Seems a bit weird that one place would use a space-separated string and another a semicolon-separated one.

https://github.com/llvm/llvm-project/pull/147990