[Lldb-commits] [lldb] [lldb] Infer GPR base size from registers when target arch is unset (PR #203498)

[Adrian Prantl via lldb-commits]

================
@@ -5505,6 +5505,9 @@ void ProcessGDBRemote::AddRemoteRegisters(
                     remote_reg_info.invalidate_regs.begin(), proc_to_lldb);
   }
 
+  if (!GetTarget().GetArchitecture().IsValid() && arch_to_use.IsValid())
+    GetTarget().SetArchitecture(arch_to_use);
----------------
adrian-prantl wrote:

Usually setting the triple for target is very dangerous because you could be overriding it with a less-accurate triple (for example arm64-apple-darwin, arm64e-apple-macos26.0 and arm64e-apple-ios-macabi-26.0 are all compatible, but less precise). But you are checking that the target's triple is invalid first, so this _seems_ okay.

https://github.com/llvm/llvm-project/pull/203498