[Lldb-commits] [lldb] [lldb] Remove incorrect eServerPacketType_notify (PR #203204)

[David Spickett via lldb-commits]

DavidSpickett wrote:

I mean we find a way to replay the packets to lldb rather than using a real server. It's sometimes tricky to do because you also need a way to observe that lldb isn't making a mistake without seeing inside of it, but we do have for example `MockGDBServerResponder`.

What you might need to do is move the GetPacketType function and others into a place where it can be unit tested. Then write API tests that are more broad like "lldb does not explode when it gets a notification while waiting for something else". So the two in combination provide good coverage.

If you have trouble figuring out how to do that, it's fine to post the fix PR first and we'll help you choose how to test it.

https://github.com/llvm/llvm-project/pull/203204