[Lldb-commits] [lldb] [LLDB] Support for DW_OP_Implicit_pointer (PR #203182)

[via lldb-commits]

github-actions[bot] wrote:

<!--PREMERGE ADVISOR COMMENT: Windows-->
# :window: Windows x64 Test Results

The build failed before running any tests. Click on a failure below to see the details.

<details>
<summary>[code=1] tools/lldb/source/Plugins/SymbolFile/DWARF/CMakeFiles/lldbPluginSymbolFileDWARF.dir/DWARFUnit.cpp.obj</summary>

```
FAILED: [code=1] tools/lldb/source/Plugins/SymbolFile/DWARF/CMakeFiles/lldbPluginSymbolFileDWARF.dir/DWARFUnit.cpp.obj
sccache C:\clang\clang-msvc\bin\clang-cl.exe  /nologo -TP -DCLANG_BUILD_STATIC -DUNICODE -D_CRT_NONSTDC_NO_DEPRECATE -D_CRT_NONSTDC_NO_WARNINGS -D_CRT_SECURE_NO_DEPRECATE -D_CRT_SECURE_NO_WARNINGS -D_ENABLE_EXTENDED_ALIGNED_STORAGE -D_GLIBCXX_ASSERTIONS -D_HAS_EXCEPTIONS=0 -D_LIBCPP_HARDENING_MODE=_LIBCPP_HARDENING_MODE_EXTENSIVE -D_SCL_SECURE_NO_DEPRECATE -D_SCL_SECURE_NO_WARNINGS -D_UNICODE -D__STDC_CONSTANT_MACROS -D__STDC_FORMAT_MACROS -D__STDC_LIMIT_MACROS -IC:\_work\llvm-project\llvm-project\build\tools\lldb\source\Plugins\SymbolFile\DWARF -IC:\_work\llvm-project\llvm-project\lldb\source\Plugins\SymbolFile\DWARF -IC:\_work\llvm-project\llvm-project\lldb\include -IC:\_work\llvm-project\llvm-project\build\tools\lldb\include -IC:\_work\llvm-project\llvm-project\build\include -IC:\_work\llvm-project\llvm-project\llvm\include -IC:\_work\llvm-project\llvm-project\llvm\..\clang\include -IC:\_work\llvm-project\llvm-project\build\tools\lldb\..\clang\include -IC:\_work\llvm-project\llvm-project\lldb\source -IC:\_work\llvm-project\llvm-project\build\tools\lldb\source /DWIN32 /D_WINDOWS   /Zc:inline /Zc:__cplusplus /Oi /Brepro /bigobj /permissive- -Werror=unguarded-availability-new /W4  -Wextra -Wno-unused-parameter -Wwrite-strings -Wcast-qual -Wmissing-field-initializers -Wimplicit-fallthrough -Wcovered-switch-default -Wno-noexcept-type -Wnon-virtual-dtor -Wdelete-non-virtual-dtor -Wsuggest-override -Wstring-conversion -Wno-pass-failed -Wmisleading-indentation -Wctad-maybe-unsupported /Gw -Wno-vla-extension /O2 /Ob2  -std:c++17 -MD   -wd4018 -wd4068 -wd4150 -wd4201 -wd4251 -wd4521 -wd4530 -wd4589 -UNDEBUG /EHs-c- /GR- /showIncludes /Fotools\lldb\source\Plugins\SymbolFile\DWARF\CMakeFiles\lldbPluginSymbolFileDWARF.dir\DWARFUnit.cpp.obj /Fdtools\lldb\source\Plugins\SymbolFile\DWARF\CMakeFiles\lldbPluginSymbolFileDWARF.dir\lldbPluginSymbolFileDWARF.pdb -c -- C:\_work\llvm-project\llvm-project\lldb\source\Plugins\SymbolFile\DWARF\DWARFUnit.cpp
C:\_work\llvm-project\llvm-project\lldb\source\Plugins\SymbolFile\DWARF\DWARFUnit.cpp(1088,13): error: allocating an object of abstract class type 'DWARFTypeUnit'
1088 |         new DWARFTypeUnit(dwarf, uid, header, *abbrevs, section, is_dwo));
|             ^
C:\_work\llvm-project\llvm-project\lldb\include\lldb/Expression/DWARFExpression.h(47,21): note: unimplemented pure virtual method 'GetDwarfOffsetByteSize' in 'DWARFTypeUnit'
47 |     virtual uint8_t GetDwarfOffsetByteSize() const = 0;
|                     ^
C:\_work\llvm-project\llvm-project\lldb\source\Plugins\SymbolFile\DWARF\DWARFUnit.cpp(1090,11): error: allocating an object of abstract class type 'DWARFCompileUnit'
1090 |       new DWARFCompileUnit(dwarf, uid, header, *abbrevs, section, is_dwo));
|           ^
C:\_work\llvm-project\llvm-project\lldb\include\lldb/Expression/DWARFExpression.h(47,21): note: unimplemented pure virtual method 'GetDwarfOffsetByteSize' in 'DWARFCompileUnit'
47 |     virtual uint8_t GetDwarfOffsetByteSize() const = 0;
|                     ^
2 errors generated.
```
</details>

If these failures are unrelated to your changes (for example tests are broken or flaky at HEAD), please open an issue at https://github.com/llvm/llvm-project/issues and add the `infrastructure` label.

https://github.com/llvm/llvm-project/pull/203182