[Lldb-commits] [lldb] [lldb][Windows] Make RM_RF a no-op on an empty argument and swallow errors (PR #203040)
Charles Zablit via lldb-commits
lldb-commits at lists.llvm.org
Wed Jun 10 09:33:24 PDT 2026
https://github.com/charles-zablit created https://github.com/llvm/llvm-project/pull/203040
This patch makes the Windows `RM_RF` a no-op on an empty argument and swallow errors, matching Unix `rm -rf`. This fixes issues in swiftlang on fresh builds.
>From efb95ee8cedc3f305a18c3c31920cc3fea1b84bc Mon Sep 17 00:00:00 2001
From: Charles Zablit <c_zablit at apple.com>
Date: Wed, 10 Jun 2026 17:28:37 +0100
Subject: [PATCH] [lldb][Windows] Make RM_RF a no-op on an empty argument and
swallow errors
---
lldb/packages/Python/lldbsuite/test/make/Makefile.rules | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/lldb/packages/Python/lldbsuite/test/make/Makefile.rules b/lldb/packages/Python/lldbsuite/test/make/Makefile.rules
index 44aa91ef7b6fc..f4318299c1164 100644
--- a/lldb/packages/Python/lldbsuite/test/make/Makefile.rules
+++ b/lldb/packages/Python/lldbsuite/test/make/Makefile.rules
@@ -44,7 +44,7 @@ ifeq "$(OS)" "Windows_NT"
CP_R = xcopy $(subst /,\,$(1)) $(subst /,\,$(2)) /s /e /y
RM = del $(subst /,\,$(1)) > nul 2>&1 || (exit 0)
RM_F = del /f /q $(subst /,\,$(1))
- RM_RF = rd /s /q $(subst /,\,$(1))
+ RM_RF = $(if $(strip $(1)),rd /s /q $(subst /,\,$(1)) > nul 2>&1 || (exit 0))
LN_SF = mklink /D "$(subst /,\,$(2))" "$(subst /,\,$(1))"
ECHO = echo $(1);
ECHO_TO_FILE = printf "%s\n" $(1) > "$(subst /,\,$(2))"
More information about the lldb-commits
mailing list