[Lldb-commits] [clang] [clang-tools-extra] [flang] [lldb] [Clang] Refactor and consolidate color diagnostic handling (PR #202441)

[Aaron Ballman via lldb-commits]

================
@@ -53,7 +54,8 @@ void clang::ProcessWarningOptions(DiagnosticsEngine &Diags,
 
   Diags.setElideType(Opts.ElideType);
   Diags.setPrintTemplateTree(Opts.ShowTemplateTree);
-  Diags.setShowColors(Opts.ShowColors);
+  Diags.setShowColors(
+      Opts.showColors(llvm::sys::Process::StandardErrHasColors()));
----------------
AaronBallman wrote:

Will this be correct if the user writes the diagnostics to a log file (`-diagnostic-log-file`) instead of the default of `stderr`?

https://github.com/llvm/llvm-project/pull/202441