[Lldb-commits] [lldb] [lldb] Add a MemoryRegionInfo cache at a process stop (PR #202509)

[Jason Molenda via lldb-commits]

================
@@ -819,6 +835,22 @@ which indicates that the register cannot be read at this current
 stop point, and lldb should not try to read the register value with
 a separate `p` read-register request, it will not succeed.
 
+`jThreadsInfo` is an array of thread-specific information, but some
+things we expedite are usually not thread-specific; this packet
+could have been structured as a Dictionary with a `threads` array
+and separate keys for non-thread specific things like this.
+
+`memory-region-info` is an array of memory region information; a
----------------
jasonmolenda wrote:

The `qMemoryRegionInfo` section says the same thing, but it is expressed differently,

>   If the stub supports identifying dirty pages within a
>   memory region, this key should always be present for all
>   `qMemoryRegionInfo` replies.  This key with no pages
>   listed (`dirty-pages:;`) indicates no dirty pages in
>   this memory region.  The *absence* of this key means
>   that this stub cannot determine dirty pages.

As for the first question of "why not say the JSON is the same as the `qMemoryRegionInfo`", well it is a tiny bit different because it's in JSON format instead of gdb remote key-value pairs.  But I can make a more explicit reference to the `qMemoryRegionInfo` documentation.

https://github.com/llvm/llvm-project/pull/202509