[Lldb-commits] [lldb] [lldb] Add a "plugin" log category to the gdb-remote channel (PR #202359)

[via lldb-commits]

llvmorg-github-actions[bot] wrote:


<!--LLVM PR SUMMARY COMMENT-->

@llvm/pr-subscribers-lldb

Author: satyanarayana reddy janga (satyajanga)

<details>
<summary>Changes</summary>

Add a GDBRLog::Plugin category (enabled with `log enable gdb-remote plugin`) for logging lldb-server plugin activity, such as the accelerator plugins.

---
Full diff: https://github.com/llvm/llvm-project/pull/202359.diff


2 Files Affected:

- (modified) lldb/source/Plugins/Process/gdb-remote/ProcessGDBRemoteLog.cpp (+1) 
- (modified) lldb/source/Plugins/Process/gdb-remote/ProcessGDBRemoteLog.h (+2-1) 


``````````diff
diff --git a/lldb/source/Plugins/Process/gdb-remote/ProcessGDBRemoteLog.cpp b/lldb/source/Plugins/Process/gdb-remote/ProcessGDBRemoteLog.cpp
index f7cd658ea58fa..9530544fd41df 100644
--- a/lldb/source/Plugins/Process/gdb-remote/ProcessGDBRemoteLog.cpp
+++ b/lldb/source/Plugins/Process/gdb-remote/ProcessGDBRemoteLog.cpp
@@ -31,6 +31,7 @@ static constexpr Log::Category g_categories[] = {
     {{"step"}, {"log step related activities"}, GDBRLog::Step},
     {{"thread"}, {"log thread events and activities"}, GDBRLog::Thread},
     {{"watch"}, {"log watchpoint related activities"}, GDBRLog::Watchpoints},
+    {{"plugin"}, {"log lldb-server plugin activities"}, GDBRLog::Plugin},
 };
 
 static Log::Channel g_channel(g_categories, GDBRLog::Packets);
diff --git a/lldb/source/Plugins/Process/gdb-remote/ProcessGDBRemoteLog.h b/lldb/source/Plugins/Process/gdb-remote/ProcessGDBRemoteLog.h
index f08453fce9547..971090ac6c8f7 100644
--- a/lldb/source/Plugins/Process/gdb-remote/ProcessGDBRemoteLog.h
+++ b/lldb/source/Plugins/Process/gdb-remote/ProcessGDBRemoteLog.h
@@ -27,7 +27,8 @@ enum class GDBRLog : Log::MaskType {
   Step = Log::ChannelFlag<8>,
   Thread = Log::ChannelFlag<9>,
   Watchpoints = Log::ChannelFlag<10>,
-  LLVM_MARK_AS_BITMASK_ENUM(Watchpoints)
+  Plugin = Log::ChannelFlag<11>, // Log lldb-server plugin activity
+  LLVM_MARK_AS_BITMASK_ENUM(Plugin)
 };
 LLVM_ENABLE_BITMASK_ENUMS_IN_NAMESPACE();
 

``````````

</details>


https://github.com/llvm/llvm-project/pull/202359