DavidSpickett wrote: I closed anything that has been addressed. Please deal with the rest (small things). The Windows failure is infra related. As long as we know the new test passes on Linux it's fine. https://github.com/llvm/llvm-project/pull/188049