[Lldb-commits] [lldb] [lldb] Handle accelerator plugin breakpoint actions on the client (PR #201489)

[satyanarayana reddy janga via lldb-commits]

satyajanga wrote:

> It would help my understanding a lot if you included an overview of the packet sequence / event sequence with these PRs. Each PR would not be the whole sequence of course but you could point out what part the PR is making changes to.
> 
> One thing I wasn't clear on was all the points where actions could be received. It seems those points are:
> 
> * The intialise packet.
> * In response to telling the server we hit a breakpoint that a plugin asked for.
> * In stop reply packets, but I'm not sure what this looks like in practice.
> 
> Which means we could get duplicates and you seem to handle that, but are you testing that behaviour too? (I didn't look too closely)
> 
> Another thing I noticed was that https://lldb.llvm.org/resources/lldbgdbremote.html#jacceleratorpluginbreakpointhit does not say what to do if the client cannot find one of the symbol's requested plugins. Should it include the key with no value, or a null value, or just leave out the key? Not a big deal but good to mention it and double check that the server side code is handling that situation.
> 
> (this area is on my mind since I recently worked on https://lldb.llvm.org/resources/lldbgdbremote.html#qsymbol which is a very similar idea, but triggered by library load rather than a breakpoint)

updated PR summary with the packet log.
and also updated documentation for the `jAcceleratorpluginbreakpointhit` 

https://github.com/llvm/llvm-project/pull/201489