[Lldb-commits] [lldb] [lldb] Handle accelerator plugin breakpoint actions on the client (PR #201489)

[David Spickett via lldb-commits]

https://github.com/DavidSpickett commented:

What's the logic for using `Debugger::ReportError` to report problems rather than logging them? Nothing else in the GDB client uses it.

I guess the justification is:
* Logging is ok if you know it exists, but only if, and is better for things that don't break the whole session (degraded register information for example).
* The errors that non-plugin users would want to ignore are pretty easy to avoid. For instance the malformed response to listing the plugins. This could happen to anyone in theory but is unlikely given that lldb-server is the one making that response.
* The remaining things should be dealt with ASAP if the user has any hope of the accelerator part working.

Which makes sense to me, but tell me if you thought along the same lines.

We could always change it later anyway. For as long as the entire accelerator plugin thing is opt in at build time, we don't have to think about what happens to random distro builds of LLDB and their users who probably don't care about accelerators.

https://github.com/llvm/llvm-project/pull/201489