[Lldb-commits] [lldb] [lldb] Add missing includes to some tests (PR #201804)

Nikolas Klauser via lldb-commits lldb-commits at lists.llvm.org
Fri Jun 5 03:58:21 PDT 2026


https://github.com/philnik777 updated https://github.com/llvm/llvm-project/pull/201804

>From 6656071ccd13eca38a91a63f17600833b03512b7 Mon Sep 17 00:00:00 2001
From: Nikolas Klauser <nikolasklauser at berlin.de>
Date: Fri, 5 Jun 2026 12:42:13 +0200
Subject: [PATCH 1/2] [lldb] Add missing include to breakpoint/main.cpp

---
 lldb/test/API/iohandler/sigint/cat.cpp           | 1 +
 lldb/test/API/tools/lldb-dap/breakpoint/main.cpp | 1 +
 2 files changed, 2 insertions(+)

diff --git a/lldb/test/API/iohandler/sigint/cat.cpp b/lldb/test/API/iohandler/sigint/cat.cpp
index 7e12cf7df7e58..368f5db75224c 100644
--- a/lldb/test/API/iohandler/sigint/cat.cpp
+++ b/lldb/test/API/iohandler/sigint/cat.cpp
@@ -1,3 +1,4 @@
+#include <cerrno>
 #include <cstdio>
 #include <string>
 #include <unistd.h>
diff --git a/lldb/test/API/tools/lldb-dap/breakpoint/main.cpp b/lldb/test/API/tools/lldb-dap/breakpoint/main.cpp
index 2206b07f19494..9788223d9d9b1 100644
--- a/lldb/test/API/tools/lldb-dap/breakpoint/main.cpp
+++ b/lldb/test/API/tools/lldb-dap/breakpoint/main.cpp
@@ -1,6 +1,7 @@
 #include <dlfcn.h>
 #include <stdexcept>
 #include <stdio.h>
+#include <stdlib.h>
 
 int twelve(int i) {
   return 12 + i; // break 12

>From de0d04521903fa83334f1a15aa1116f71e76e12c Mon Sep 17 00:00:00 2001
From: Nikolas Klauser <nikolasklauser at berlin.de>
Date: Fri, 5 Jun 2026 12:58:09 +0200
Subject: [PATCH 2/2] Move tested lines

---
 .../lldb-dap/breakpoint/TestDAP_breakpointLocations.py    | 8 ++++----
 1 file changed, 4 insertions(+), 4 deletions(-)

diff --git a/lldb/test/API/tools/lldb-dap/breakpoint/TestDAP_breakpointLocations.py b/lldb/test/API/tools/lldb-dap/breakpoint/TestDAP_breakpointLocations.py
index 1df5923b18b70..37e7d2ad907f0 100644
--- a/lldb/test/API/tools/lldb-dap/breakpoint/TestDAP_breakpointLocations.py
+++ b/lldb/test/API/tools/lldb-dap/breakpoint/TestDAP_breakpointLocations.py
@@ -80,10 +80,10 @@ def test_column_breakpoints(self):
         # test more portable, only check that all expected breakpoints are
         # presented, but also accept additional breakpoints.
         expected_breakpoints = [
-            {"column": 39, "line": 40},
-            {"column": 51, "line": 40},
-            {"column": 3, "line": 42},
-            {"column": 18, "line": 42},
+            {"column": 39, "line": 41},
+            {"column": 51, "line": 41},
+            {"column": 3, "line": 43},
+            {"column": 18, "line": 43},
         ]
         for bp in expected_breakpoints:
             self.assertIn(bp, response["body"]["breakpoints"])



More information about the lldb-commits mailing list