[Lldb-commits] [lldb] [lldb][Windows] skip TestDAP_attachCommands.py and TestDAP_launch_extra_launch_commands.py (PR #201796)

Charles Zablit via lldb-commits lldb-commits at lists.llvm.org
Fri Jun 5 03:37:43 PDT 2026


https://github.com/charles-zablit updated https://github.com/llvm/llvm-project/pull/201796

>From b01c03c3d9eaf61789f414a279177a9da3f79361 Mon Sep 17 00:00:00 2001
From: Charles Zablit <c_zablit at apple.com>
Date: Fri, 5 Jun 2026 11:21:20 +0100
Subject: [PATCH 1/2] [lldb][Windows] skip TestDAP_attachCommands.py and
 TestDAP_launch_extra_launch_commands.py

---
 .../tools/lldb-dap/attach-commands/TestDAP_attachCommands.py   | 1 +
 .../lldb-dap/launch/TestDAP_launch_extra_launch_commands.py    | 3 ++-
 2 files changed, 3 insertions(+), 1 deletion(-)

diff --git a/lldb/test/API/tools/lldb-dap/attach-commands/TestDAP_attachCommands.py b/lldb/test/API/tools/lldb-dap/attach-commands/TestDAP_attachCommands.py
index f24a32edbaa7b..5c19abf534a84 100644
--- a/lldb/test/API/tools/lldb-dap/attach-commands/TestDAP_attachCommands.py
+++ b/lldb/test/API/tools/lldb-dap/attach-commands/TestDAP_attachCommands.py
@@ -12,6 +12,7 @@
 class TestDAP_attachCommands(lldbdap_testcase.DAPTestCaseBase):
     SHARED_BUILD_TESTCASE = False
 
+    @skipIfWindows  # Fails in pre-merge CI
     @skipIfNetBSD  # Hangs on NetBSD as well
     def test_commands(self):
         """
diff --git a/lldb/test/API/tools/lldb-dap/launch/TestDAP_launch_extra_launch_commands.py b/lldb/test/API/tools/lldb-dap/launch/TestDAP_launch_extra_launch_commands.py
index ad48af6364aba..f8511e67f7cd6 100644
--- a/lldb/test/API/tools/lldb-dap/launch/TestDAP_launch_extra_launch_commands.py
+++ b/lldb/test/API/tools/lldb-dap/launch/TestDAP_launch_extra_launch_commands.py
@@ -2,7 +2,7 @@
 Test lldb-dap launch request.
 """
 
-from lldbsuite.test.decorators import skipIf
+from lldbsuite.test.decorators import skipIf, skipIfWindows
 from lldbsuite.test.lldbtest import line_number
 import lldbdap_testcase
 
@@ -12,6 +12,7 @@ class TestDAP_launch_extra_launch_commands(lldbdap_testcase.DAPTestCaseBase):
     Tests the "launchCommands" with extra launching settings
     """
 
+    @skipIfWindows  # Fails in pre-merge CI
     # Flakey on 32-bit Arm Linux.
     @skipIf(oslist=["linux"], archs=["arm$"])
     def test(self):

>From ff0678408b23cbbfd685a2352c8996662747ce66 Mon Sep 17 00:00:00 2001
From: Charles Zablit <c_zablit at apple.com>
Date: Fri, 5 Jun 2026 11:37:30 +0100
Subject: [PATCH 2/2] fixup! [lldb][Windows] skip TestDAP_attachCommands.py and
 TestDAP_launch_extra_launch_commands.py

---
 .../tools/lldb-dap/attach-commands/TestDAP_attachCommands.py    | 2 +-
 .../lldb-dap/launch/TestDAP_launch_extra_launch_commands.py     | 2 +-
 2 files changed, 2 insertions(+), 2 deletions(-)

diff --git a/lldb/test/API/tools/lldb-dap/attach-commands/TestDAP_attachCommands.py b/lldb/test/API/tools/lldb-dap/attach-commands/TestDAP_attachCommands.py
index 5c19abf534a84..525783b3785fb 100644
--- a/lldb/test/API/tools/lldb-dap/attach-commands/TestDAP_attachCommands.py
+++ b/lldb/test/API/tools/lldb-dap/attach-commands/TestDAP_attachCommands.py
@@ -12,7 +12,7 @@
 class TestDAP_attachCommands(lldbdap_testcase.DAPTestCaseBase):
     SHARED_BUILD_TESTCASE = False
 
-    @skipIfWindows  # Fails in pre-merge CI
+    @skipIfWindows  # Wait for module events fails.
     @skipIfNetBSD  # Hangs on NetBSD as well
     def test_commands(self):
         """
diff --git a/lldb/test/API/tools/lldb-dap/launch/TestDAP_launch_extra_launch_commands.py b/lldb/test/API/tools/lldb-dap/launch/TestDAP_launch_extra_launch_commands.py
index f8511e67f7cd6..cc3c4764a5fd7 100644
--- a/lldb/test/API/tools/lldb-dap/launch/TestDAP_launch_extra_launch_commands.py
+++ b/lldb/test/API/tools/lldb-dap/launch/TestDAP_launch_extra_launch_commands.py
@@ -12,7 +12,7 @@ class TestDAP_launch_extra_launch_commands(lldbdap_testcase.DAPTestCaseBase):
     Tests the "launchCommands" with extra launching settings
     """
 
-    @skipIfWindows  # Fails in pre-merge CI
+    @skipIfWindows  # Wait for module events fails.
     # Flakey on 32-bit Arm Linux.
     @skipIf(oslist=["linux"], archs=["arm$"])
     def test(self):



More information about the lldb-commits mailing list