[Lldb-commits] [lldb] [lldb-dap][Windows] skip TestDAP_restart_console (PR #201587)

[via lldb-commits]

llvmorg-github-actions[bot] wrote:


<!--LLVM PR SUMMARY COMMENT-->

@llvm/pr-subscribers-lldb

Author: Charles Zablit (charles-zablit)

<details>
<summary>Changes</summary>

`TestDAP_restart_console` is already failing on Windows. It reliably crashes (UNRESOLVED) on some Windows version, including inside Docker containers.

This is preventing us from enabling pre-merge CI testing for lldb on Windows in https://github.com/llvm/llvm-project/pull/198906.

This patch skips the test entirely. See https://github.com/llvm/llvm-project/issues/200840 for more details.

---
Full diff: https://github.com/llvm/llvm-project/pull/201587.diff


1 Files Affected:

- (modified) lldb/test/API/tools/lldb-dap/restart/TestDAP_restart_console.py (+2-2) 


``````````diff
diff --git a/lldb/test/API/tools/lldb-dap/restart/TestDAP_restart_console.py b/lldb/test/API/tools/lldb-dap/restart/TestDAP_restart_console.py
index c80a3cdc10d95..e10d6791eeaf2 100644
--- a/lldb/test/API/tools/lldb-dap/restart/TestDAP_restart_console.py
+++ b/lldb/test/API/tools/lldb-dap/restart/TestDAP_restart_console.py
@@ -12,7 +12,7 @@
 @skipIfBuildType(["debug"])
 class TestDAP_restart_console(lldbdap_testcase.DAPTestCaseBase):
     @skipIfAsan
-    @expectedFailureWindows
+    @skipIfWindows  # https://github.com/llvm/llvm-project/issues/200840
     @skipIf(oslist=["linux"], archs=["arm$"])  # Always times out on buildbot
     def test_basic_functionality(self):
         """
@@ -61,7 +61,7 @@ def test_basic_functionality(self):
         self.continue_to_exit()
 
     @skipIfAsan
-    @expectedFailureWindows
+    @skipIfWindows  # https://github.com/llvm/llvm-project/issues/200840
     @skipIf(oslist=["linux"], archs=["arm$"])  # Always times out on buildbot
     def test_stopOnEntry(self):
         """

``````````

</details>


https://github.com/llvm/llvm-project/pull/201587