[Lldb-commits] [lldb] Implement reportsOriginalInstructions GDB remote feature (PR #201176)

via lldb-commits lldb-commits at lists.llvm.org
Thu Jun 4 04:12:07 PDT 2026


github-actions[bot] wrote:

<!--PREMERGE ADVISOR COMMENT: Windows-->
# :window: Windows x64 Test Results

The build failed before running any tests. Click on a failure below to see the details.

<details>
<summary>[code=1] tools/lldb/source/Target/CMakeFiles/lldbTarget.dir/Process.cpp.obj</summary>

```
FAILED: [code=1] tools/lldb/source/Target/CMakeFiles/lldbTarget.dir/Process.cpp.obj
sccache C:\clang\clang-msvc\bin\clang-cl.exe  /nologo -TP -DUNICODE -D_CRT_NONSTDC_NO_DEPRECATE -D_CRT_NONSTDC_NO_WARNINGS -D_CRT_SECURE_NO_DEPRECATE -D_CRT_SECURE_NO_WARNINGS -D_ENABLE_EXTENDED_ALIGNED_STORAGE -D_GLIBCXX_ASSERTIONS -D_HAS_EXCEPTIONS=0 -D_LIBCPP_HARDENING_MODE=_LIBCPP_HARDENING_MODE_EXTENSIVE -D_SCL_SECURE_NO_DEPRECATE -D_SCL_SECURE_NO_WARNINGS -D_UNICODE -D__STDC_CONSTANT_MACROS -D__STDC_FORMAT_MACROS -D__STDC_LIMIT_MACROS -IC:\_work\llvm-project\llvm-project\build\tools\lldb\source\Target -IC:\_work\llvm-project\llvm-project\lldb\source\Target -IC:\_work\llvm-project\llvm-project\lldb\include -IC:\_work\llvm-project\llvm-project\build\tools\lldb\include -IC:\_work\llvm-project\llvm-project\build\include -IC:\_work\llvm-project\llvm-project\llvm\include -IC:\_work\llvm-project\llvm-project\llvm\..\clang\include -IC:\_work\llvm-project\llvm-project\build\tools\lldb\..\clang\include -IC:\_work\llvm-project\llvm-project\lldb\source -IC:\_work\llvm-project\llvm-project\build\tools\lldb\source /DWIN32 /D_WINDOWS   /Zc:inline /Zc:__cplusplus /Oi /Brepro /bigobj /permissive- -Werror=unguarded-availability-new /W4  -Wextra -Wno-unused-parameter -Wwrite-strings -Wcast-qual -Wmissing-field-initializers -Wimplicit-fallthrough -Wcovered-switch-default -Wno-noexcept-type -Wnon-virtual-dtor -Wdelete-non-virtual-dtor -Wsuggest-override -Wstring-conversion -Wno-pass-failed -Wmisleading-indentation -Wctad-maybe-unsupported /Gw -Wno-vla-extension /O2 /Ob2  -std:c++17 -MD   -wd4018 -wd4068 -wd4150 -wd4201 -wd4251 -wd4521 -wd4530 -wd4589 -UNDEBUG /EHs-c- /GR- /showIncludes /Fotools\lldb\source\Target\CMakeFiles\lldbTarget.dir\Process.cpp.obj /Fdtools\lldb\source\Target\CMakeFiles\lldbTarget.dir\lldbTarget.pdb -c -- C:\_work\llvm-project\llvm-project\lldb\source\Target\Process.cpp
C:\_work\llvm-project\llvm-project\lldb\source\Target\Process.cpp(1825,13): error: 'this' cannot be implicitly captured in this context
1825 |            !ReportsOriginalOpcodes())) {
|             ^
C:\_work\llvm-project\llvm-project\lldb\source\Target\Process.cpp(1822,35): note: explicitly capture 'this'
1822 |                                buf](BreakpointSite *bp_site) -> void {
|                                   ^
|                                   , this
C:\_work\llvm-project\llvm-project\lldb\source\Target\Process.cpp(1821,31): error: no viable conversion from '(lambda at C:\_work\llvm-project\llvm-project\lldb\source\Target\Process.cpp:1821:31)' to 'const std::function<void (lldb_private::BreakpointSite *)>'
1821 |     bp_sites_in_range.ForEach([bp_addr, size,
|                               ^~~~~~~~~~~~~~~
1822 |                                buf](BreakpointSite *bp_site) -> void {
|                                ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
1823 |       if (bp_site->GetType() == BreakpointSite::eSoftware ||
|       ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
1824 |           (bp_site->GetType() == BreakpointSite::eExternal &&
|           ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
1825 |            !ReportsOriginalOpcodes())) {
|            ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
1826 |         addr_t intersect_addr;
|         ~~~~~~~~~~~~~~~~~~~~~~
1827 |         size_t intersect_size;
|         ~~~~~~~~~~~~~~~~~~~~~~
1828 |         size_t opcode_offset;
|         ~~~~~~~~~~~~~~~~~~~~~
1829 |         if (bp_site->IntersectsRange(bp_addr, size, &intersect_addr,
|         ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
1830 |                                      &intersect_size, &opcode_offset)) {
|                                      ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
1831 |           assert(bp_addr <= intersect_addr && intersect_addr < bp_addr + size);
|           ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
1832 |           assert(bp_addr < intersect_addr + intersect_size &&
|           ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
1833 |                  intersect_addr + intersect_size <= bp_addr + size);
|                  ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
1834 |           assert(opcode_offset + intersect_size <= bp_site->GetByteSize());
|           ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
1835 |           size_t buf_offset = intersect_addr - bp_addr;
|           ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
1836 |           ::memcpy(buf + buf_offset,
|           ~~~~~~~~~~~~~~~~~~~~~~~~~~
C:\BuildTools\VC\Tools\MSVC\14.44.35207\include\functional(1096,5): note: candidate constructor not viable: no known conversion from '(lambda at C:\_work\llvm-project\llvm-project\lldb\source\Target\Process.cpp:1821:31)' to 'nullptr_t' (aka 'std::nullptr_t') for 1st argument
1096 |     function(nullptr_t) noexcept {}
|     ^        ~~~~~~~~~
C:\BuildTools\VC\Tools\MSVC\14.44.35207\include\functional(1098,5): note: candidate constructor not viable: no known conversion from '(lambda at C:\_work\llvm-project\llvm-project\lldb\source\Target\Process.cpp:1821:31)' to 'const function<void (lldb_private::BreakpointSite *)> &' for 1st argument
1098 |     function(const function& _Right) {
|     ^        ~~~~~~~~~~~~~~~~~~~~~~
C:\BuildTools\VC\Tools\MSVC\14.44.35207\include\functional(1149,5): note: candidate constructor not viable: no known conversion from '(lambda at C:\_work\llvm-project\llvm-project\lldb\source\Target\Process.cpp:1821:31)' to 'function<void (lldb_private::BreakpointSite *)> &&' for 1st argument
1149 |     function(function&& _Right) noexcept {
|     ^        ~~~~~~~~~~~~~~~~~
C:\BuildTools\VC\Tools\MSVC\14.44.35207\include\functional(1103,5): note: candidate template ignored: requirement 'conjunction_v<std::negation<std::is_same<(lambda at C:\_work\llvm-project\llvm-project\lldb\source\Target\Process.cpp:1821:31), std::function<void (lldb_private::BreakpointSite *)>>>, std::_Is_invocable_r<void, (lambda at C:\_work\llvm-project\llvm-project\lldb\source\Target\Process.cpp:1821:31) &, lldb_private::BreakpointSite *>>' was not satisfied [with _Fx = (lambda at C:\_work\llvm-project\llvm-project\lldb\source\Target\Process.cpp:1821:31)]
1103 |     function(_Fx&& _Func) {
|     ^
C:\_work\llvm-project\llvm-project\lldb\include\lldb/Breakpoint/StopPointSiteList.h(145,60): note: passing argument to parameter 'callback' here
145 |   void ForEach(std::function<void(StopPointSite *)> const &callback) {
|                                                            ^
2 errors generated.
```
</details>
<details>
<summary>[code=1] tools/lldb/source/Plugins/Process/gdb-remote/CMakeFiles/lldbPluginProcessGDBRemote.dir/GDBRemoteCommunicationClient.cpp.obj</summary>

```
FAILED: [code=1] tools/lldb/source/Plugins/Process/gdb-remote/CMakeFiles/lldbPluginProcessGDBRemote.dir/GDBRemoteCommunicationClient.cpp.obj
sccache C:\clang\clang-msvc\bin\clang-cl.exe  /nologo -TP -DUNICODE -D_CRT_NONSTDC_NO_DEPRECATE -D_CRT_NONSTDC_NO_WARNINGS -D_CRT_SECURE_NO_DEPRECATE -D_CRT_SECURE_NO_WARNINGS -D_ENABLE_EXTENDED_ALIGNED_STORAGE -D_GLIBCXX_ASSERTIONS -D_HAS_EXCEPTIONS=0 -D_LIBCPP_HARDENING_MODE=_LIBCPP_HARDENING_MODE_EXTENSIVE -D_SCL_SECURE_NO_DEPRECATE -D_SCL_SECURE_NO_WARNINGS -D_UNICODE -D__STDC_CONSTANT_MACROS -D__STDC_FORMAT_MACROS -D__STDC_LIMIT_MACROS -IC:\_work\llvm-project\llvm-project\build\tools\lldb\source\Plugins\Process\gdb-remote -IC:\_work\llvm-project\llvm-project\lldb\source\Plugins\Process\gdb-remote -IC:\_work\llvm-project\llvm-project\lldb\include -IC:\_work\llvm-project\llvm-project\build\tools\lldb\include -IC:\_work\llvm-project\llvm-project\build\include -IC:\_work\llvm-project\llvm-project\llvm\include -IC:\_work\llvm-project\llvm-project\llvm\..\clang\include -IC:\_work\llvm-project\llvm-project\build\tools\lldb\..\clang\include -IC:\_work\llvm-project\llvm-project\lldb\source -IC:\_work\llvm-project\llvm-project\build\tools\lldb\source /DWIN32 /D_WINDOWS   /Zc:inline /Zc:__cplusplus /Oi /Brepro /bigobj /permissive- -Werror=unguarded-availability-new /W4  -Wextra -Wno-unused-parameter -Wwrite-strings -Wcast-qual -Wmissing-field-initializers -Wimplicit-fallthrough -Wcovered-switch-default -Wno-noexcept-type -Wnon-virtual-dtor -Wdelete-non-virtual-dtor -Wsuggest-override -Wstring-conversion -Wno-pass-failed -Wmisleading-indentation -Wctad-maybe-unsupported /Gw -Wno-vla-extension /O2 /Ob2  -std:c++17 -MD   -wd4018 -wd4068 -wd4150 -wd4201 -wd4251 -wd4521 -wd4530 -wd4589 -UNDEBUG /EHs-c- /GR- /showIncludes /Fotools\lldb\source\Plugins\Process\gdb-remote\CMakeFiles\lldbPluginProcessGDBRemote.dir\GDBRemoteCommunicationClient.cpp.obj /Fdtools\lldb\source\Plugins\Process\gdb-remote\CMakeFiles\lldbPluginProcessGDBRemote.dir\lldbPluginProcessGDBRemote.pdb -c -- C:\_work\llvm-project\llvm-project\lldb\source\Plugins\Process\gdb-remote\GDBRemoteCommunicationClient.cpp
C:\_work\llvm-project\llvm-project\lldb\source\Plugins\Process\gdb-remote\GDBRemoteCommunicationClient.cpp(694,5): error: 'this' argument to member function 'GetRemoteQSupported' has type 'const lldb_private::process_gdb_remote::GDBRemoteCommunicationClient', but function is not marked const
694 |     GetRemoteQSupported();
|     ^~~~~~~~~~~~~~~~~~~
C:\_work\llvm-project\llvm-project\lldb\source\Plugins\Process\gdb-remote\GDBRemoteCommunicationClient.cpp(364,36): note: 'GetRemoteQSupported' declared here
364 | void GDBRemoteCommunicationClient::GetRemoteQSupported() {
|                                    ^
1 error generated.
```
</details>

If these failures are unrelated to your changes (for example tests are broken or flaky at HEAD), please open an issue at https://github.com/llvm/llvm-project/issues and add the `infrastructure` label.

https://github.com/llvm/llvm-project/pull/201176


More information about the lldb-commits mailing list