[Lldb-commits] [lldb] Implement reportsOriginalInstructions GDB remote feature (PR #201176)

[David Spickett via lldb-commits]

================
@@ -687,6 +689,13 @@ bool GDBRemoteCommunicationClient::GetMemoryTaggingSupported() {
   return m_supports_memory_tagging == eLazyBoolYes;
 }
 
+bool GDBRemoteCommunicationClient::GetReportsOriginalInstructions() const {
+  if (m_supports_reportingOriginalInsts == eLazyBoolCalculate) {
+    GetRemoteQSupported();
+  }
+  return m_supports_reportingOriginalInsts == eLazyBoolYes;
----------------
DavidSpickett wrote:

We usually use "supports" for actions we can ask the server to do. For a "feature" like this that just tells us the behaviour of the stub, I would just use the name. 

So in this case: `m_reports_original_instructions`

If this were something we had to request that the stub did, then "supports" would make more sense. Rather than something it just did without us asking for it.

If there was a "pleaseReportOriginalInstructions" packet to enable it, then "supports" makes total sense. As there isn't, it's just an innate property of the stub.

https://github.com/llvm/llvm-project/pull/201176