[Lldb-commits] [lldb] [lldb] Introduce RegisterType base class for all register type classes (PR #196960)

[David Spickett via lldb-commits]

================
@@ -0,0 +1,62 @@
+//===-- RegisterType.h ------------------------------------------*- C++ -*-===//
+//
+// Part of the LLVM Project, under the Apache License v2.0 with LLVM Exceptions.
+// See https://llvm.org/LICENSE.txt for license information.
+// SPDX-License-Identifier: Apache-2.0 WITH LLVM-exception
+//
+//===----------------------------------------------------------------------===//
+
+#ifndef LLDB_TARGET_REGISTERTYPE_H
+#define LLDB_TARGET_REGISTERTYPE_H
+
+#include <string>
+#include <unordered_set>
+#include <vector>
+
+namespace lldb_private {
+
+class Stream;
+class Log;
+
+class RegisterType {
----------------
DavidSpickett wrote:

Covered most of this in a general comment on this PR.
```
  virtual Status FromXML(...);
  virtual ToXML(Stream &strm);
```
This part definitely agree with. I want to move a lot of that code out of `ProcessGDBRemote.cpp` so we can test it, and get better error reporting as a result. (currently I do log errors, but it's not very rigorous)

https://github.com/llvm/llvm-project/pull/196960