[Lldb-commits] [lldb] [lldb][gdb-remote] Forward client terminal size to lldb-server (PR #201141)

[Charles Zablit via lldb-commits]

================
@@ -1181,6 +1181,30 @@ These packets must be sent  _prior_ to sending a "A" packet.
 a target after making a connection to a GDB server that isn't already connected to
 an inferior process.
 
+## QSetSTDIOWindowSize:cols=\<N\>;rows=\<N\>
+
+Set the terminal window size for the inferior's stdio pseudo-terminal prior to
+sending an "A" packet.
+
+When launching a program that uses a pseudo-terminal (PTY) for stdio, this
+packet specifies the initial terminal dimensions:
+```
+QSetSTDIOWindowSize:cols=<N>;rows=<N>
+```
+Both `cols` and `rows` must be non-zero unsigned 16-bit integers. The packet
+must be sent _prior_ to sending an "A" packet. On the server side, the
+dimensions are applied to the PTY via `TIOCSWINSZ` (POSIX) or the equivalent
+platform mechanism (e.g. `ConPTY` resize on Windows).
+
+The response is either:
+* `OK`: dimensions accepted.
+* `ENN`: malformed packet or zero value for `cols`/`rows`.
----------------
charles-zablit wrote:

> So when the server responds the most it can say is that it will try to use them later.

Pretty much yes. Do you think we should still do some sort of validation? `32767` is not a reasonable terminal width, warning the client that something went wrong if that happens could be valuable for development.

https://github.com/llvm/llvm-project/pull/201141