[Lldb-commits] [lldb] [lldb][gdb-remote] Forward client terminal size to lldb-server (PR #201141)

[David Spickett via lldb-commits]

================
@@ -963,6 +966,33 @@ GDBRemoteCommunicationServerCommon::Handle_QSetSTDERR(
   return SendErrorResponse(17);
 }
 
+GDBRemoteCommunication::PacketResult
+GDBRemoteCommunicationServerCommon::Handle_QSetSTDIOWindowSize(
+    StringExtractorGDBRemote &packet) {
+  // Format: "QSetSTDIOWindowSize:cols=N;rows=N"
+  packet.SetFilePos(::strlen("QSetSTDIOWindowSize:"));
----------------
DavidSpickett wrote:

Beside the point of this PR, but seeing this, I wonder if we could just do this automatically and save every handler doing it. Maybe there is some corner case I don't know about.

Probably something where we send 2 similar packets to the same handler and it uses the name somehow.

https://github.com/llvm/llvm-project/pull/201141