[Lldb-commits] [lldb] [lldb-server] Add breakpoint support to accelerator plugin protocol (PR #200584)

[Greg Clayton via lldb-commits]

================
@@ -159,9 +159,49 @@ STUB REPLIES:  [{"plugin_name":"amdgpu","session_name":"AMD GPU Session","identi
 If no accelerator plugins are installed, the server does not advertise the
 `accelerator-plugins+` feature and this packet should not be sent.
 
+Each `accelerator_action` may include a `breakpoints` array requesting
+breakpoints to be set in the native process. See
+`jAcceleratorPluginBreakpointHit` for the callback when those breakpoints
+are hit.
+
 In future patches, each `accelerator_action` will include additional fields
-such as breakpoints to set in the native process, connection info for
-secondary debug sessions, and synchronization options.
+such as connection info for secondary debug sessions and synchronization
+options.
+
+**Priority To Implement:** Low. Only needed for hardware accelerator
+debugging support.
+
+## jAcceleratorPluginBreakpointHit
+
+Sent by the client when a breakpoint requested by an accelerator plugin
+(via `jAcceleratorPluginInitialize`) is hit in the native process. This
----------------
clayborg wrote:

Breakpoints can be set by any `AcceleratorActions` contents. The `jAcceleratorPluginInitialize` does return an `AcceleratorActions`, but breakpoint responses can include new accelerator actions.

https://github.com/llvm/llvm-project/pull/200584