[Lldb-commits] [lldb] [lldb][Windows] Use captured error in ConnectionGenericFile::Read (PR #200803)

[via lldb-commits]

llvmorg-github-actions[bot] wrote:


<!--LLVM PR SUMMARY COMMENT-->

@llvm/pr-subscribers-lldb

Author: Charles Zablit (charles-zablit)

<details>
<summary>Changes</summary>

Use the captured value on both branches so the reported error matches the one that was tested against.

---
Full diff: https://github.com/llvm/llvm-project/pull/200803.diff


1 Files Affected:

- (modified) lldb/source/Host/windows/ConnectionGenericFileWindows.cpp (+1-1) 


``````````diff
diff --git a/lldb/source/Host/windows/ConnectionGenericFileWindows.cpp b/lldb/source/Host/windows/ConnectionGenericFileWindows.cpp
index 8507dffde4166..8a177bcf571ba 100644
--- a/lldb/source/Host/windows/ConnectionGenericFileWindows.cpp
+++ b/lldb/source/Host/windows/ConnectionGenericFileWindows.cpp
@@ -175,7 +175,7 @@ size_t ConnectionGenericFile::Read(void *dst, size_t dst_len,
       return finish(0, eConnectionStatusEndOfFile, 0);
     }
     // An unknown error occurred.  Fail out.
-    return finish(0, eConnectionStatusError, ::GetLastError());
+    return finish(0, eConnectionStatusError, read_error);
   }
 
   if (!read_result || m_read_pending) {

``````````

</details>


https://github.com/llvm/llvm-project/pull/200803