[Lldb-commits] [lldb] [lldb] Fix up comment placement (NFC) (PR #200671)

Dave Lee via lldb-commits lldb-commits at lists.llvm.org
Sun May 31 09:28:41 PDT 2026


https://github.com/kastiglione created https://github.com/llvm/llvm-project/pull/200671

None

>From f526639dc7998f5f0658f4d8ba2d013f8bef414d Mon Sep 17 00:00:00 2001
From: Dave Lee <davelee.com at gmail.com>
Date: Sun, 31 May 2026 09:27:52 -0700
Subject: [PATCH] [lldb] Fix up comment placement (NFC)

---
 lldb/source/Commands/CommandObjectFrame.cpp | 8 ++++----
 1 file changed, 4 insertions(+), 4 deletions(-)

diff --git a/lldb/source/Commands/CommandObjectFrame.cpp b/lldb/source/Commands/CommandObjectFrame.cpp
index 742f7026464f0..5c79d758bafd7 100644
--- a/lldb/source/Commands/CommandObjectFrame.cpp
+++ b/lldb/source/Commands/CommandObjectFrame.cpp
@@ -731,6 +731,10 @@ may even involve JITing and running code in the target program.)");
             valobj_sp = frame->GetValueForVariableExpressionPath(
                 entry.ref(), m_varobj_options.use_dynamic, expr_path_options,
                 var_sp, error);
+            // Check only the `error` argument, because doing
+            // `valobj_sp->GetError()` will update the value and potentially
+            // return a new error that happens during the update, even if
+            // `GetValueForVariableExpressionPath` reported no errors.
             if (valobj_sp && error.Success()) {
               result.GetValueObjectList().Append(valobj_sp);
 
@@ -770,10 +774,6 @@ may even involve JITing and running code in the target program.)");
                     break;
                   }
               if (!found_recognized) {
-                // Check only the `error` argument, because doing
-                // `valobj_sp->GetError()` will update the value and potentially
-                // return a new error that happens during the update, even if
-                // `GetValueForVariableExpressionPath` reported no errors.
                 if (error.Fail())
                   result.SetError(error.takeError());
                 else



More information about the lldb-commits mailing list