[Lldb-commits] [lldb] [lldb][windows] fix scope_exit warning (PR #200439)
via lldb-commits
lldb-commits at lists.llvm.org
Fri May 29 08:54:55 PDT 2026
llvmorg-github-actions[bot] wrote:
<!--LLVM PR SUMMARY COMMENT-->
@llvm/pr-subscribers-lldb
Author: Charles Zablit (charles-zablit)
<details>
<summary>Changes</summary>
Using the constructor rather than `make_scope_exit` is preferred.
---
Full diff: https://github.com/llvm/llvm-project/pull/200439.diff
1 Files Affected:
- (modified) lldb/source/Plugins/Process/Windows/Common/DebuggerThread.cpp (+1-1)
``````````diff
diff --git a/lldb/source/Plugins/Process/Windows/Common/DebuggerThread.cpp b/lldb/source/Plugins/Process/Windows/Common/DebuggerThread.cpp
index 22a836f9cbed5..a672f24209090 100644
--- a/lldb/source/Plugins/Process/Windows/Common/DebuggerThread.cpp
+++ b/lldb/source/Plugins/Process/Windows/Common/DebuggerThread.cpp
@@ -497,7 +497,7 @@ ConvertNtDevicePathToDosPath(llvm::ArrayRef<wchar_t> nt_path) {
::GetLastError());
return std::nullopt;
}
- auto close_iter = llvm::make_scope_exit([&] { ::FindVolumeClose(vol_iter); });
+ llvm::scope_exit close_iter([&] { ::FindVolumeClose(vol_iter); });
do {
// FindFirstVolumeW yields "\\?\Volume{GUID}\".
``````````
</details>
https://github.com/llvm/llvm-project/pull/200439
More information about the lldb-commits
mailing list