[Lldb-commits] [lldb] [lldb-server] Add accelerator plugin infrastructure for debugging hardware accelerators like gpus (PR #198907)

[David Spickett via lldb-commits]

https://github.com/DavidSpickett commented:

> NOTE: Sorry for the big patch, We tried to make self contained as much as possible.

I thought it was quite compact actually. Maybe because the changes are varied. The more similar the changes are to each other, the less tolerance I have for a large PR.

> jAcceleratorPluginInitialize GDB remote packet and its implementation in handlers, request and response.

Ultimately I don't care too much about the name, so this is more about understanding, but can you tell me what `jAcceleratorPluginInitialize` actually initializes and what work is involved in that?

At a glance it seems that it is more like `jAcceleratorPluginList`. The result may be used to initialize something in `lldb` but that's like calling memory read `memoryReadBufferInitialize`. The server doesn't care that the client is going to do whatever action with the result in that case.

If it looks this way just because the mock plugin is, a mock plugin, fair enough. If you could give some examples of work that needs to be done at this step for real plugins, that would be very helpful.

https://github.com/llvm/llvm-project/pull/198907