[Lldb-commits] [lldb] [lldb] Don't assume non-erased DenseMap entries remain valid after erase. NFC (PR #199499)

[LLVM Continuous Integration via lldb-commits]

llvm-ci wrote:

LLVM Buildbot has detected a new failure on builder `lldb-aarch64-windows` running on `linaro-armv8-windows-msvc-05` while building `lldb` at step 6 "test".

Full details are available at: https://lab.llvm.org/buildbot/#/builders/141/builds/18751

<details>
<summary>Here is the relevant piece of the build log for the reference</summary>

```
Step 6 (test) failure: build (failure)
...
UNSUPPORTED: lldb-api :: functionalities/thread/concurrent_events/TestConcurrentWatchpointDelayWatchpointOneBreakpoint.py (722 of 2533)
UNSUPPORTED: lldb-api :: functionalities/thread/concurrent_events/TestConcurrentWatchpointWithDelayWatchpointThreads.py (723 of 2533)
UNSUPPORTED: lldb-api :: functionalities/thread/concurrent_events/exit/TestConcurrentThreadExit.py (724 of 2533)
UNSUPPORTED: lldb-api :: functionalities/thread/crash_during_step/TestCrashDuringStep.py (725 of 2533)
UNSUPPORTED: lldb-api :: functionalities/thread/create_after_attach/TestCreateAfterAttach.py (726 of 2533)
PASS: lldb-api :: functionalities/thread/exit_during_break/TestExitDuringBreak.py (727 of 2533)
XFAIL: lldb-api :: functionalities/thread/create_during_step/TestCreateDuringStep.py (728 of 2533)
UNSUPPORTED: lldb-api :: functionalities/thread/exit_during_expression/TestExitDuringExpression.py (729 of 2533)
UNSUPPORTED: lldb-api :: functionalities/thread/exit_during_step/TestExitDuringStep.py (730 of 2533)
PASS: lldb-api :: functionalities/thread/finish-from-empty-func/TestEmptyFuncThreadStepOut.py (731 of 2533)
FAIL: lldb-api :: functionalities/thread/jump/TestThreadJump.py (732 of 2533)
******************** TEST 'lldb-api :: functionalities/thread/jump/TestThreadJump.py' FAILED ********************
Script:
--
C:/Users/tcwg/scoop/apps/python/current/python.exe C:/Users/tcwg/llvm-worker/lldb-aarch64-windows/llvm-project/lldb\test\API\dotest.py -u CXXFLAGS -u CFLAGS --env LLVM_LIBS_DIR=C:/Users/tcwg/llvm-worker/lldb-aarch64-windows/build/./lib --env LLVM_INCLUDE_DIR=C:/Users/tcwg/llvm-worker/lldb-aarch64-windows/build/include --env LLVM_TOOLS_DIR=C:/Users/tcwg/llvm-worker/lldb-aarch64-windows/build/./bin --triple aarch64-pc-windows-msvc --build-dir C:/Users/tcwg/llvm-worker/lldb-aarch64-windows/build/lldb-test-build.noindex --lldb-module-cache-dir C:/Users/tcwg/llvm-worker/lldb-aarch64-windows/build/lldb-test-build.noindex/module-cache-lldb\lldb-api --clang-module-cache-dir C:/Users/tcwg/llvm-worker/lldb-aarch64-windows/build/lldb-test-build.noindex/module-cache-clang\lldb-api --executable C:/Users/tcwg/llvm-worker/lldb-aarch64-windows/build/./bin/lldb.exe --compiler C:/Users/tcwg/llvm-worker/lldb-aarch64-windows/build/./bin/clang.exe --dsymutil C:/Users/tcwg/llvm-worker/lldb-aarch64-windows/build/./bin/dsymutil.exe --make C:/Users/tcwg/scoop/shims/make.exe --llvm-tools-dir C:/Users/tcwg/llvm-worker/lldb-aarch64-windows/build/./bin --lldb-obj-root C:/Users/tcwg/llvm-worker/lldb-aarch64-windows/build/tools/lldb --lldb-libs-dir C:/Users/tcwg/llvm-worker/lldb-aarch64-windows/build/./lib --cmake-build-type Release --skip-category=watchpoint --env LLDB_LAUNCH_FLAG_USE_PIPES=1 C:\Users\tcwg\llvm-worker\lldb-aarch64-windows\llvm-project\lldb\test\API\functionalities\thread\jump -p TestThreadJump.py
--
Exit Code: 1

Command Output (stdout):
--
lldb version 23.0.0git (https://github.com/llvm/llvm-project.git revision 8446759ee610fe5ad1c5ab9cb2239ef3ad2e4c30)
  clang revision 8446759ee610fe5ad1c5ab9cb2239ef3ad2e4c30
  llvm revision 8446759ee610fe5ad1c5ab9cb2239ef3ad2e4c30
Skipping the following test categories: watchpoint, libc++, libstdcxx, dwo, dsym, gmodules, debugserver, objc, fork, pexpect


--
Command Output (stderr):
--
UNSUPPORTED: LLDB (C:\Users\tcwg\llvm-worker\lldb-aarch64-windows\build\bin\clang.exe-aarch64) :: test_dsym (TestThreadJump.ThreadJumpTestCase.test_dsym) (test case does not fall in any category of interest for this run) 

FAIL: LLDB (C:\Users\tcwg\llvm-worker\lldb-aarch64-windows\build\bin\clang.exe-aarch64) :: test_dwarf (TestThreadJump.ThreadJumpTestCase.test_dwarf)

Log Files:

 - C:\Users\tcwg\llvm-worker\lldb-aarch64-windows\build\lldb-test-build.noindex\functionalities\thread\jump\TestThreadJump\Failure_test_dwarf.log

UNSUPPORTED: LLDB (C:\Users\tcwg\llvm-worker\lldb-aarch64-windows\build\bin\clang.exe-aarch64) :: test_dwo (TestThreadJump.ThreadJumpTestCase.test_dwo) (test case does not fall in any category of interest for this run) 

UNSUPPORTED: LLDB (C:\Users\tcwg\llvm-worker\lldb-aarch64-windows\build\bin\clang.exe-aarch64) :: test_jump_offset_dsym (TestThreadJump.ThreadJumpTestCase.test_jump_offset_dsym) (test case does not fall in any category of interest for this run) 

PASS: LLDB (C:\Users\tcwg\llvm-worker\lldb-aarch64-windows\build\bin\clang.exe-aarch64) :: test_jump_offset_dwarf (TestThreadJump.ThreadJumpTestCase.test_jump_offset_dwarf)

UNSUPPORTED: LLDB (C:\Users\tcwg\llvm-worker\lldb-aarch64-windows\build\bin\clang.exe-aarch64) :: test_jump_offset_dwo (TestThreadJump.ThreadJumpTestCase.test_jump_offset_dwo) (test case does not fall in any category of interest for this run) 

======================================================================

FAIL: test_dwarf (TestThreadJump.ThreadJumpTestCase.test_dwarf)


```

</details>

https://github.com/llvm/llvm-project/pull/199499