[Lldb-commits] [clang] [clang-tools-extra] [lldb] [clang] implement CWG1980 and CWG2064: instantiation-dependency improvements (PR #190495)

[Corentin Jabot via lldb-commits]

================
@@ -1412,13 +1412,18 @@ TemplateArgumentLoc Sema::getTemplateArgumentPackExpansionPattern(
   }
 
   case TemplateArgument::Expression: {
-    PackExpansionExpr *Expansion
-      = cast<PackExpansionExpr>(Argument.getAsExpr());
+    CanonicalizationKindOrNone CanonKind = std::nullopt;
+    Expr *OrigE = OrigLoc.getSourceExpression(), *E = OrigE;
+    if (!E) { // FIXME: Does this ever happen?
+      E = Argument.getAsExpr();
+      CanonKind = Argument.getExprCanonKind();
+    }
----------------
cor3ntin wrote:

Maybe put an assert? It beats having dead code

https://github.com/llvm/llvm-project/pull/190495