[Lldb-commits] [lldb] [lldb/test] Downgrade missing-libcxx check from error to warning (PR #199262)

[Michael Buch via lldb-commits]

================
@@ -205,13 +205,16 @@ if(TARGET clang)
             "LLDB_TEST_LIBCXX_ROOT_DIR to it.")
       endif()
     else()
-      # We require libcxx for the test suite, so if we aren't building it,
-      # provide a helpful error about how to resolve the situation.
+      # The LLDB test suite uses libc++ for many tests. If it isn't being
+      # built in-tree, warn and let the suite fall back to whatever libc++
+      # the compiler picks up by default (the system one on Darwin); the
+      # libc++-specific tests will be skipped or run against system libc++.
       if(NOT LLDB_HAS_LIBCXX)
-        message(SEND_ERROR
-          "LLDB test suite requires libc++, but it is currently disabled. "
-          "Please add `libcxx` to `LLVM_ENABLE_RUNTIMES` or disable tests via "
-          "`LLDB_INCLUDE_TESTS=OFF`.")
+        message(WARNING
+          "LLDB test suite normally uses an in-tree libc++; it is currently "
----------------
Michael137 wrote:

I'd just keep the old phrasing tbh. I'm not sure users that aren't deeply familiar with the API test suite will understand the skip/fall back comment.

Do we skip all the data formatter tests if no local libc++ is available? If we're downgrading this to a warning, I think we should make sure that they are being skipped. Otherwise it just gives a false sense of security to someone working on the data formatters

https://github.com/llvm/llvm-project/pull/199262