[Lldb-commits] [lldb] [lldb][test] Use octal literal (NFC) (PR #198343)

Dave Lee via lldb-commits lldb-commits at lists.llvm.org
Mon May 18 10:04:16 PDT 2026


https://github.com/kastiglione updated https://github.com/llvm/llvm-project/pull/198343

>From 735e349da7ec74b45481dc40e6943a943ad2a682 Mon Sep 17 00:00:00 2001
From: Dave Lee <davelee.com at gmail.com>
Date: Mon, 18 May 2026 09:59:02 -0700
Subject: [PATCH 1/2] [lldb][test] Use octal literal (NFC)

---
 lldb/packages/Python/lldbsuite/test/dotest.py   | 4 ++--
 lldb/packages/Python/lldbsuite/test/lldbtest.py | 4 ++--
 2 files changed, 4 insertions(+), 4 deletions(-)

diff --git a/lldb/packages/Python/lldbsuite/test/dotest.py b/lldb/packages/Python/lldbsuite/test/dotest.py
index 7f73fce14bcdd..f1abc4b63db0e 100644
--- a/lldb/packages/Python/lldbsuite/test/dotest.py
+++ b/lldb/packages/Python/lldbsuite/test/dotest.py
@@ -1089,8 +1089,8 @@ def run_suite():
             % (configuration.lldb_platform_working_dir)
         )
         error = lldb.remote_platform.MakeDirectory(
-            configuration.lldb_platform_working_dir, 448
-        )  # 448 = 0o700
+            configuration.lldb_platform_working_dir, 0o700
+        )
         if error.Fail():
             raise Exception(
                 "making remote directory '%s': %s"
diff --git a/lldb/packages/Python/lldbsuite/test/lldbtest.py b/lldb/packages/Python/lldbsuite/test/lldbtest.py
index fe9a492132fc2..dcfd22de57976 100644
--- a/lldb/packages/Python/lldbsuite/test/lldbtest.py
+++ b/lldb/packages/Python/lldbsuite/test/lldbtest.py
@@ -743,8 +743,8 @@ def setPlatformWorkingDir(self):
         for c in components:
             remote_test_dir = lldbutil.join_remote_paths(remote_test_dir, c)
             error = lldb.remote_platform.MakeDirectory(
-                remote_test_dir, 448
-            )  # 448 = 0o700
+                remote_test_dir, 0o700
+            )
             if error.Fail():
                 raise Exception(
                     "making remote directory '%s': %s" % (remote_test_dir, error)

>From a9ffe6d25ba9002aab0485bb91af70b947b04470 Mon Sep 17 00:00:00 2001
From: Dave Lee <davelee.com at gmail.com>
Date: Mon, 18 May 2026 10:03:53 -0700
Subject: [PATCH 2/2] formatting

---
 lldb/packages/Python/lldbsuite/test/lldbtest.py | 4 +---
 1 file changed, 1 insertion(+), 3 deletions(-)

diff --git a/lldb/packages/Python/lldbsuite/test/lldbtest.py b/lldb/packages/Python/lldbsuite/test/lldbtest.py
index dcfd22de57976..a91654d0bc986 100644
--- a/lldb/packages/Python/lldbsuite/test/lldbtest.py
+++ b/lldb/packages/Python/lldbsuite/test/lldbtest.py
@@ -742,9 +742,7 @@ def setPlatformWorkingDir(self):
         remote_test_dir = configuration.lldb_platform_working_dir
         for c in components:
             remote_test_dir = lldbutil.join_remote_paths(remote_test_dir, c)
-            error = lldb.remote_platform.MakeDirectory(
-                remote_test_dir, 0o700
-            )
+            error = lldb.remote_platform.MakeDirectory(remote_test_dir, 0o700)
             if error.Fail():
                 raise Exception(
                     "making remote directory '%s': %s" % (remote_test_dir, error)



More information about the lldb-commits mailing list