[Lldb-commits] [lldb] [lldb][windows] Reset m_pty in ProcessLaunchInfo::Clear (PR #197717)
Charles Zablit via lldb-commits
lldb-commits at lists.llvm.org
Thu May 14 08:08:25 PDT 2026
https://github.com/charles-zablit created https://github.com/llvm/llvm-project/pull/197717
`ProcessLaunchInfo::Clear()` resets every member it owns except `m_pty`. In `lldb-server.exe` this trips an assert.
This patch ensures that `m_pty` is reset as well. It fixes all the `types/*` tests when running `check-lldb` with `LLDB_USE_LLDB_SERVER=1` on Windows.
>From d8d60c67e4729fc497a1c755620a790998653ec2 Mon Sep 17 00:00:00 2001
From: Charles Zablit <c_zablit at apple.com>
Date: Thu, 14 May 2026 17:03:58 +0200
Subject: [PATCH] [lldb][windows] Reset m_pty in ProcessLaunchInfo::Clear
---
lldb/source/Host/common/ProcessLaunchInfo.cpp | 1 +
1 file changed, 1 insertion(+)
diff --git a/lldb/source/Host/common/ProcessLaunchInfo.cpp b/lldb/source/Host/common/ProcessLaunchInfo.cpp
index b5b82c7475822..e69de81700c88 100644
--- a/lldb/source/Host/common/ProcessLaunchInfo.cpp
+++ b/lldb/source/Host/common/ProcessLaunchInfo.cpp
@@ -201,6 +201,7 @@ void ProcessLaunchInfo::Clear() {
m_resume_count = 0;
m_listener_sp.reset();
m_hijack_listener_sp.reset();
+ m_pty.reset();
}
void ProcessLaunchInfo::NoOpMonitorCallback(lldb::pid_t pid, int signal,
More information about the lldb-commits
mailing list