[Lldb-commits] [lldb] [lldb][windows] Reset m_pty in ProcessLaunchInfo::Clear (PR #197717)

[via lldb-commits]

llvmorg-github-actions[bot] wrote:


<!--LLVM PR SUMMARY COMMENT-->

@llvm/pr-subscribers-lldb

Author: Charles Zablit (charles-zablit)

<details>
<summary>Changes</summary>

`ProcessLaunchInfo::Clear()` resets every member it owns except `m_pty`. In `lldb-server.exe` this trips an assert.

This patch ensures that `m_pty` is reset as well. It fixes all the `types/*` tests when running  `check-lldb` with `LLDB_USE_LLDB_SERVER=1` on Windows.

---
Full diff: https://github.com/llvm/llvm-project/pull/197717.diff


1 Files Affected:

- (modified) lldb/source/Host/common/ProcessLaunchInfo.cpp (+1) 


``````````diff
diff --git a/lldb/source/Host/common/ProcessLaunchInfo.cpp b/lldb/source/Host/common/ProcessLaunchInfo.cpp
index b5b82c7475822..e69de81700c88 100644
--- a/lldb/source/Host/common/ProcessLaunchInfo.cpp
+++ b/lldb/source/Host/common/ProcessLaunchInfo.cpp
@@ -201,6 +201,7 @@ void ProcessLaunchInfo::Clear() {
   m_resume_count = 0;
   m_listener_sp.reset();
   m_hijack_listener_sp.reset();
+  m_pty.reset();
 }
 
 void ProcessLaunchInfo::NoOpMonitorCallback(lldb::pid_t pid, int signal,

``````````

</details>


https://github.com/llvm/llvm-project/pull/197717