[Lldb-commits] [lldb] [LLDB][Part 3] Support enabling/disabling InstrumentationRuntime plugins in an debug session (PR #193334)

[Jonas Devlieghere via lldb-commits]

================
@@ -6538,6 +6538,58 @@ Process::GetInstrumentationRuntime(lldb::InstrumentationRuntimeType type) {
     return (*pos).second;
 }
 
+llvm::Error
+Process::SetInstrumentationRuntimeEnabled(InstrumentationRuntimeType irt,
+                                          bool enabled) {
+  assert(IsAlive());
----------------
JDevlieghere wrote:

Since this is a public method and there's nothing holding the process alive between checking it and calling this method, should this be an llvm::Error instead of an assert?

https://github.com/llvm/llvm-project/pull/193334