[Lldb-commits] [lldb] Revert "[lldb] Do not refcount breakpoints in lldb-server" (PR #196561)

[LLVM Continuous Integration via lldb-commits]

llvm-ci wrote:

LLVM Buildbot has detected a new failure on builder `lldb-aarch64-windows` running on `linaro-armv8-windows-msvc-05` while building `lldb` at step 6 "test".

Full details are available at: https://lab.llvm.org/buildbot/#/builders/141/builds/18360

<details>
<summary>Here is the relevant piece of the build log for the reference</summary>

```
Step 6 (test) failure: build (failure)
...
UNSUPPORTED: lldb-api :: functionalities/breakpoint/jit_loader_rtdyld_elf/TestJitBreakPoint.py (362 of 2523)
PASS: lldb-api :: functionalities/breakpoint/nested_breakpoint_commands/TestNestedBreakpointCommands.py (363 of 2523)
PASS: lldb-api :: functionalities/breakpoint/move_nearest/TestMoveNearest.py (364 of 2523)
UNSUPPORTED: lldb-api :: functionalities/breakpoint/objc/TestObjCBreakpoints.py (365 of 2523)
PASS: lldb-api :: functionalities/breakpoint/same_cu_name/TestFileBreakpointsSameCUName.py (366 of 2523)
XFAIL: lldb-api :: functionalities/breakpoint/scripted_bkpt/was_hit/TestWasHit.py (367 of 2523)
PASS: lldb-api :: functionalities/breakpoint/scripted_bkpt/TestScriptedResolver.py (368 of 2523)
PASS: lldb-api :: functionalities/breakpoint/source_regexp/TestSourceRegexBreakpoints.py (369 of 2523)
PASS: lldb-api :: functionalities/breakpoint/serialize/TestBreakpointSerialization.py (370 of 2523)
PASS: lldb-api :: functionalities/breakpoint/step_over_breakpoint/TestStepOverBreakpoint.py (371 of 2523)
FAIL: lldb-api :: functionalities/breakpoint/two_hits_one_actual/TestTwoHitsOneActual.py (372 of 2523)
******************** TEST 'lldb-api :: functionalities/breakpoint/two_hits_one_actual/TestTwoHitsOneActual.py' FAILED ********************
Script:
--
C:/Users/tcwg/scoop/apps/python/current/python.exe C:/Users/tcwg/llvm-worker/lldb-aarch64-windows/llvm-project/lldb\test\API\dotest.py -u CXXFLAGS -u CFLAGS --env LLVM_LIBS_DIR=C:/Users/tcwg/llvm-worker/lldb-aarch64-windows/build/./lib --env LLVM_INCLUDE_DIR=C:/Users/tcwg/llvm-worker/lldb-aarch64-windows/build/include --env LLVM_TOOLS_DIR=C:/Users/tcwg/llvm-worker/lldb-aarch64-windows/build/./bin --triple aarch64-pc-windows-msvc --build-dir C:/Users/tcwg/llvm-worker/lldb-aarch64-windows/build/lldb-test-build.noindex --lldb-module-cache-dir C:/Users/tcwg/llvm-worker/lldb-aarch64-windows/build/lldb-test-build.noindex/module-cache-lldb\lldb-api --clang-module-cache-dir C:/Users/tcwg/llvm-worker/lldb-aarch64-windows/build/lldb-test-build.noindex/module-cache-clang\lldb-api --executable C:/Users/tcwg/llvm-worker/lldb-aarch64-windows/build/./bin/lldb.exe --compiler C:/Users/tcwg/llvm-worker/lldb-aarch64-windows/build/./bin/clang.exe --dsymutil C:/Users/tcwg/llvm-worker/lldb-aarch64-windows/build/./bin/dsymutil.exe --make C:/Users/tcwg/scoop/shims/make.exe --llvm-tools-dir C:/Users/tcwg/llvm-worker/lldb-aarch64-windows/build/./bin --lldb-obj-root C:/Users/tcwg/llvm-worker/lldb-aarch64-windows/build/tools/lldb --lldb-libs-dir C:/Users/tcwg/llvm-worker/lldb-aarch64-windows/build/./lib --cmake-build-type Release --skip-category=watchpoint --env LLDB_LAUNCH_FLAG_USE_PIPES=1 C:\Users\tcwg\llvm-worker\lldb-aarch64-windows\llvm-project\lldb\test\API\functionalities\breakpoint\two_hits_one_actual -p TestTwoHitsOneActual.py
--
Exit Code: 1

Command Output (stdout):
--
lldb version 23.0.0git (https://github.com/llvm/llvm-project.git revision ee44ba80855a91b42c4a66f33c41abaa7e79b099)
  clang revision ee44ba80855a91b42c4a66f33c41abaa7e79b099
  llvm revision ee44ba80855a91b42c4a66f33c41abaa7e79b099
Skipping the following test categories: watchpoint, libc++, libstdcxx, dwo, dsym, gmodules, debugserver, objc, fork, pexpect


--
Command Output (stderr):
--
FAIL: LLDB (C:\Users\tcwg\llvm-worker\lldb-aarch64-windows\build\bin\clang.exe-aarch64) :: test_two_hits_one_actual (TestTwoHitsOneActual.TestTwoHitsOneActual.test_two_hits_one_actual)

Log Files:

 - C:\Users\tcwg\llvm-worker\lldb-aarch64-windows\build\lldb-test-build.noindex\functionalities\breakpoint\two_hits_one_actual\TestTwoHitsOneActual\Failure_test_two_hits_one_actual.log

======================================================================

FAIL: test_two_hits_one_actual (TestTwoHitsOneActual.TestTwoHitsOneActual.test_two_hits_one_actual)

   There can be many tests in a test case - describe this test here.

----------------------------------------------------------------------

Traceback (most recent call last):

  File "C:\Users\tcwg\llvm-worker\lldb-aarch64-windows\llvm-project\lldb\packages\Python\lldbsuite\test\decorators.py", line 160, in wrapper

    return func(*args, **kwargs)


```

</details>

https://github.com/llvm/llvm-project/pull/196561