[Lldb-commits] [lldb] [lldb] Add completion support for direct ivars (PR #195187)

[via lldb-commits]

================
@@ -475,6 +476,27 @@ static void PrivateAutoComplete(
         &prefix_path, // Anything that has been resolved already will be in here
     const CompilerType &compiler_type, CompletionRequest &request);
 
+/// Get the CompilerType of the instance variable (this/self) for direct ivar
+/// completion. Returns an invalid CompilerType if not in a method context.
+static CompilerType GetInstanceVariableType(StackFrame &frame,
----------------
jimingham wrote:

I thought "Instance Variable" meant one of the ivars of a class.  IIUC, you are using it to mean the ObjectPointerType, which is confusing.  When I see "GetInstanceVariableType I expect to be passed the name of the instance variable.

I guess we already had a SymbolContext::GetInstanceVariableName but that also doesn't make sense, as the natural question on seeing that API is "which instance variable"...

https://github.com/llvm/llvm-project/pull/195187