[Lldb-commits] [lldb] [lldb] fix the install-lldb target (PR #196070)

[Alex Langford via lldb-commits]

================
@@ -72,6 +64,15 @@ function(finish_swig_lua swig_target lldb_lua_bindings_dir lldb_lua_target_dir)
     add_llvm_install_targets(${lldb_lua_library_install_target}
                             COMPONENT ${lldb_lua_library_target}
                             DEPENDS ${lldb_lua_library_target})
+    # Tools that link liblldb need the lua bindings installed alongside.
+    foreach(tool lldb lldb-dap)
----------------
bulbazord wrote:

Instead of handwriting this list in two places, can we create a common list that Lua and python can share? `add_lldb_executable` can tell what should go into this list via `_lldb_links_liblldb_check`.

I suggest this because there may be another lldb tool we want to install one day. You'd be back to manually fixing these lists instead of having it automatically picked up like the rest of the install target tracking.

https://github.com/llvm/llvm-project/pull/196070