[Lldb-commits] [lldb] be4a02f - [lldb] Immediately connect in webinspector-wasm (#196368)
via lldb-commits
lldb-commits at lists.llvm.org
Thu May 7 10:01:59 PDT 2026
Author: Jonas Devlieghere
Date: 2026-05-07T17:01:54Z
New Revision: be4a02f9efd31a0c36361fb1393398c27f42a05f
URL: https://github.com/llvm/llvm-project/commit/be4a02f9efd31a0c36361fb1393398c27f42a05f
DIFF: https://github.com/llvm/llvm-project/commit/be4a02f9efd31a0c36361fb1393398c27f42a05f.diff
LOG: [lldb] Immediately connect in webinspector-wasm (#196368)
Call `EnsureConnected` in the `PlatformWebInspectorWasm` ctor so the
platform reports being connected after selecting in. The lazy approach
resulted in confusion due to the "Connected: no" in the `platform
select` output:
```
(lldb) platform select webinspector-wasm
Platform: webinspector-wasm
Connected: no
```
Added:
Modified:
lldb/source/Plugins/Platform/WebAssembly/PlatformWebInspectorWasm.cpp
lldb/source/Plugins/Platform/WebAssembly/PlatformWebInspectorWasm.h
Removed:
################################################################################
diff --git a/lldb/source/Plugins/Platform/WebAssembly/PlatformWebInspectorWasm.cpp b/lldb/source/Plugins/Platform/WebAssembly/PlatformWebInspectorWasm.cpp
index fc60a98f46862..c23647f204692 100644
--- a/lldb/source/Plugins/Platform/WebAssembly/PlatformWebInspectorWasm.cpp
+++ b/lldb/source/Plugins/Platform/WebAssembly/PlatformWebInspectorWasm.cpp
@@ -30,6 +30,13 @@ static constexpr llvm::StringLiteral kServerBinary =
static constexpr uint8_t kConnectAttempts = 5;
static constexpr auto kConnectDelay = std::chrono::milliseconds(100);
+PlatformWebInspectorWasm::PlatformWebInspectorWasm() {
+ if (llvm::Error err = EnsureConnected()) {
+ LLDB_LOG_ERROR(GetLog(LLDBLog::Platform), std::move(err),
+ "EnsureConnected failed: {0}");
+ }
+}
+
llvm::StringRef PlatformWebInspectorWasm::GetPluginDescriptionStatic() {
return "Platform for debugging Wasm via WebInspector";
}
diff --git a/lldb/source/Plugins/Platform/WebAssembly/PlatformWebInspectorWasm.h b/lldb/source/Plugins/Platform/WebAssembly/PlatformWebInspectorWasm.h
index 52286b4532ebc..d20308ecfb2f7 100644
--- a/lldb/source/Plugins/Platform/WebAssembly/PlatformWebInspectorWasm.h
+++ b/lldb/source/Plugins/Platform/WebAssembly/PlatformWebInspectorWasm.h
@@ -45,7 +45,7 @@ class PlatformWebInspectorWasm : public PlatformWasm {
private:
static lldb::PlatformSP CreateInstance(bool force, const ArchSpec *arch);
- PlatformWebInspectorWasm() = default;
+ PlatformWebInspectorWasm();
llvm::Error LaunchPlatformServer();
llvm::Error EnsureConnected();
More information about the lldb-commits
mailing list