[Lldb-commits] [lldb] ed70ce5 - [lldb][CMake] Force OBJECT libraries to also be STATIC (#196222)

[via lldb-commits]

Author: Jonas Devlieghere
Date: 2026-05-06T19:52:43-07:00
New Revision: ed70ce563c7f4e7d510b6ad2e7ec10a91c8a436c

URL: https://github.com/llvm/llvm-project/commit/ed70ce563c7f4e7d510b6ad2e7ec10a91c8a436c
DIFF: https://github.com/llvm/llvm-project/commit/ed70ce563c7f4e7d510b6ad2e7ec10a91c8a436c.diff

LOG: [lldb][CMake] Force OBJECT libraries to also be STATIC (#196222)

When add_lldb_library is called with OBJECT, llvm_add_library would also
produce a SHARED variant under BUILD_SHARED_LIBS=ON. That variant fails
to link because a5a13ca29186 intentionally moved lldbDAP's LINK_LIBS to
its consumers.

Pass STATIC alongside OBJECT so the secondary variant is always an
archive, matching the LLVMTableGenCommon pattern. Fixes
BUILD_SHARED_LIBS=ON breakage reported on #196108.

Added: 
    

Modified: 
    lldb/cmake/modules/AddLLDB.cmake

Removed: 
    


################################################################################
diff  --git a/lldb/cmake/modules/AddLLDB.cmake b/lldb/cmake/modules/AddLLDB.cmake
index 93b6bd2740abb..50f32303db63b 100644
--- a/lldb/cmake/modules/AddLLDB.cmake
+++ b/lldb/cmake/modules/AddLLDB.cmake
@@ -76,7 +76,11 @@ function(add_lldb_library name)
   elseif (PARAM_SHARED)
     set(libkind SHARED)
   elseif (PARAM_OBJECT)
-    set(libkind OBJECT)
+    # Pass STATIC alongside OBJECT so that under BUILD_SHARED_LIBS=ON the
+    # secondary library variant llvm_add_library produces is a STATIC archive
+    # rather than a SHARED library. OBJECT consumers in LLDB carry no LINK_LIBS
+    # of their own (consumers add them), so a SHARED variant would fail to link.
+    set(libkind "OBJECT;STATIC")
   else ()
     # PARAM_STATIC or library type unspecified. BUILD_SHARED_LIBS
     # does not control the kind of libraries created for LLDB,