[Lldb-commits] [lldb] Add a breakpoint override resolver feature to lldb (PR #195392)

[Med Ismail Bennani via lldb-commits]

================
@@ -931,6 +945,53 @@ void Target::GetBreakpointNames(std::vector<std::string> &names) {
   llvm::sort(names);
 }
 
+llvm::Expected<lldb::user_id_t>
+Target::AddBreakpointResolverOverride(llvm::StringRef class_name,
+                                      StructuredData::DictionarySP args_data_sp,
+                                      llvm::StringRef description) {
+  if (class_name.empty())
+    return LLDB_INVALID_INDEX64;
+
+  StructuredDataImpl impl;
+  impl.SetObjectSP(args_data_sp);
+
+  ScriptedBreakpointResolverOverride *new_override =
+      new ScriptedBreakpointResolverOverride(*this, std::string(description),
+                                             std::string(class_name), impl);
+  llvm::Error error = new_override->Validate();
----------------
medismailben wrote:

Could you group the classname and the args dictionary into a ScriptedMetadataSP ? That's how other interfaces do it.

https://github.com/llvm/llvm-project/pull/195392