[Lldb-commits] [lldb] [lldb][windows] fix install-lldb target on Windows (PR #196070)

[Charles Zablit via lldb-commits]

https://github.com/charles-zablit updated https://github.com/llvm/llvm-project/pull/196070

>From b210688f23bcb0b12e3d8e5c2adf9b40a8460b2f Mon Sep 17 00:00:00 2001
From: Charles Zablit <c_zablit at apple.com>
Date: Wed, 6 May 2026 14:27:54 +0100
Subject: [PATCH 1/2] [lldb][windows] fix install-lldb target on Windows

---
 lldb/CMakeLists.txt | 22 ++++++++++++++++++++++
 1 file changed, 22 insertions(+)

diff --git a/lldb/CMakeLists.txt b/lldb/CMakeLists.txt
index 0a1ca5cf391ef..3291e6621193a 100644
--- a/lldb/CMakeLists.txt
+++ b/lldb/CMakeLists.txt
@@ -165,6 +165,28 @@ if (LLDB_ENABLE_LUA)
   finish_swig_lua("lldb-lua" "${lldb_lua_bindings_dir}" "${LLDB_LUA_CPATH}")
 endif()
 
+set(lldb_runtime_install_deps)
+if(TARGET install-liblldb)
+  list(APPEND lldb_runtime_install_deps liblldb)
+endif()
+if(LLDB_ENABLE_PYTHON AND TARGET install-lldb-python-scripts)
+  list(APPEND lldb_runtime_install_deps lldb-python-scripts)
+endif()
+if(LLDB_ENABLE_LUA AND TARGET install-lldb-lua-library)
+  list(APPEND lldb_runtime_install_deps lldb-lua-library)
+endif()
+
+foreach(lldb_tool lldb lldb-dap)
+  foreach(dep ${lldb_runtime_install_deps})
+    if(TARGET install-${lldb_tool} AND TARGET install-${dep})
+      add_dependencies(install-${lldb_tool} install-${dep})
+    endif()
+    if(TARGET install-${lldb_tool}-stripped AND TARGET install-${dep}-stripped)
+      add_dependencies(install-${lldb_tool}-stripped install-${dep}-stripped)
+    endif()
+  endforeach()
+endforeach()
+
 set(LLDB_INCLUDE_UNITTESTS ON)
 if (NOT TARGET llvm_gtest)
   set(LLDB_INCLUDE_UNITTESTS OFF)

>From 2034139ceb1aab8e8ba583a9c11cdba140fca5ab Mon Sep 17 00:00:00 2001
From: Charles Zablit <c_zablit at apple.com>
Date: Wed, 6 May 2026 17:06:13 +0100
Subject: [PATCH 2/2] fixup! [lldb][windows] fix install-lldb target on Windows

---
 lldb/CMakeLists.txt | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/lldb/CMakeLists.txt b/lldb/CMakeLists.txt
index 3291e6621193a..fe242e2c4d112 100644
--- a/lldb/CMakeLists.txt
+++ b/lldb/CMakeLists.txt
@@ -169,10 +169,10 @@ set(lldb_runtime_install_deps)
 if(TARGET install-liblldb)
   list(APPEND lldb_runtime_install_deps liblldb)
 endif()
-if(LLDB_ENABLE_PYTHON AND TARGET install-lldb-python-scripts)
+if(TARGET install-lldb-python-scripts)
   list(APPEND lldb_runtime_install_deps lldb-python-scripts)
 endif()
-if(LLDB_ENABLE_LUA AND TARGET install-lldb-lua-library)
+if(TARGET install-lldb-lua-library)
   list(APPEND lldb_runtime_install_deps lldb-lua-library)
 endif()