[Lldb-commits] [lldb] [lldb] Do not refcount breakpoints in lldb-server (PR #195858)

[Pavel Labath via lldb-commits]

labath wrote:

> I didn't know we were doing reference counting in the first place. According to the GDB protocol, what this PR does is required/recommended (depending on how you read "should").
> 
> https://sourceware.org/gdb/current/onlinedocs/gdb.html/Packets.html#Packets
> 
> > ‘z type,addr,kind’
> > <...>
> > To avoid potential problems with duplicate packets, the operations should be implemented in an idempotent way.

Ah, thanks! I knew I got the "refcounting is wrong" idea from somewhere even before encountering this issue, but I couldn't find that now. I was only reading the `z0` description, and think to scroll up to see the general `z` comment.

https://github.com/llvm/llvm-project/pull/195858