[Lldb-commits] [lldb] [lldb] Do not refcount breakpoints in lldb-server (PR #195858)

[Felipe de Azevedo Piovezan via lldb-commits]

felipepiovezan wrote:

Also worth mentioning that LLDB already had an implicit assumption about this. For example, inside `ProcessGDBRemote::EnableBreakpointSite`:

```
  // Breakpoint already exists and is enabled
  if (IsBreakpointSitePhysicallyEnabled(*bp_site)) {
    LLDB_LOGF(log,
              "ProcessGDBRemote::EnableBreakpointSite (size_id = %" PRIu64
              ") address = 0x%" PRIx64 " -- SUCCESS (already enabled)",
              site_id, (uint64_t)addr);
    return Status();
  }
```

(If you blame these lines you will reach some NFC commits that I did along the way of the delayed breakpoints feature, but the same behavior was there previously)

https://github.com/llvm/llvm-project/pull/195858