[Lldb-commits] [lldb] [lldb] Flush delayed breakpoints before eagerly changing one (PR #195815)

[Pavel Labath via lldb-commits]

================
@@ -1763,6 +1763,14 @@ Process::CreateBreakpointSite(const BreakpointLocationSP &constituent,
       BreakpointResolver::ResolverTy::AddressResolver;
   bool should_be_eager = use_hardware || bp_from_address;
 
+  // If this breakpoint must be eager, flush the breakpoint queue in case there
+  // is an interaction between the sites in the queue and this new site.
+  if (should_be_eager)
+    if (auto E = FlushDelayedBreakpoints())
----------------
labath wrote:

I don't think this is a good use of auto (https://llvm.org/docs/CodingStandards.html#beware-unnecessary-copies-with-auto), particularly as it resolves to a different type (Error vs. Status) than the `auto` directly below it.

https://github.com/llvm/llvm-project/pull/195815