[Lldb-commits] [lldb] [lldb] New expedited register specfication for unavailable regs (PR #193894)

[Jonas Devlieghere via lldb-commits]

================
@@ -41,27 +41,46 @@ GDBRemoteRegisterContext::GDBRemoteRegisterContext(
   // Resize our vector of bools to contain one bool for every register. We will
   // use these boolean values to know when a register value is valid in
   // m_reg_data.
-  m_reg_valid.resize(m_reg_info_sp->GetNumRegisters());
+  m_reg_valid.resize(m_reg_info_sp->GetNumRegisters(), eLazyBoolCalculate);
 
   // Make a heap based buffer that is big enough to store all registers
-  DataBufferSP reg_data_sp(
-      new DataBufferHeap(m_reg_info_sp->GetRegisterDataByteSize(), 0));
+  DataBufferSP reg_data_sp(new DataBufferHeap(
+      m_reg_info_sp->GetRegisterDataByteSize(), eLazyBoolCalculate));
----------------
JDevlieghere wrote:

This is a mistake, right? The second argument is the fill byte, so this is going to initialize the data buffer to `-1` which truncated to uint8_t is `0xFF`. 

https://github.com/llvm/llvm-project/pull/193894