[Lldb-commits] [clang] [clang-tools-extra] [lldb] [llvm] [MC][AsmParser]: Don't use SourceMgr::AddIncludeFile when opening .incbin files (PR #194254)

[Alexis Engelke via lldb-commits]

================
@@ -133,6 +133,10 @@ class LLVM_ABI File {
   getBuffer(const Twine &Name, int64_t FileSize = -1,
             bool RequiresNullTerminator = true, bool IsVolatile = false) = 0;
 
+  virtual ErrorOr<std::unique_ptr<MemoryBuffer>>
+  getSliceBuffer(const Twine &Name, int64_t Offset = 0, int64_t Count = -1,
+                 bool IsVolatile = false) = 0;
----------------
aengelke wrote:

This should have an out-of-line default implementation that uses getBuffer internally. Then all the other implementations that currently are unimplemented become unneeded.

https://github.com/llvm/llvm-project/pull/194254