[Lldb-commits] [clang] [compiler-rt] [lldb] [llvm] Add ARMv8-M and ARMv8.1-M support for Darwin (PR #195184)

[David Green via lldb-commits]

================
@@ -2839,6 +2839,24 @@ Triple MachOObjectFile::getArchTriple(uint32_t CPUType, uint32_t CPUSubType,
       if (ArchFlag)
         *ArchFlag = "armv7s";
       return Triple("armv7s-apple-darwin");
+    case MachO::CPU_SUBTYPE_ARM_V8M_BASE:
+      if (McpuDefault)
+        *McpuDefault = "cortex-m23";
+      if (ArchFlag)
+        *ArchFlag = "armv8m.base";
+      return Triple("thumbv8m-apple-darwin");
+    case MachO::CPU_SUBTYPE_ARM_V8M_MAIN:
+      if (McpuDefault)
+        *McpuDefault = "cortex-m23";
----------------
davemgreen wrote:

Oh I should have said "for a v8m.main cpu". You are right that both are v8-m but cortex-m23 is armv8m.base so thumb-1 only and smaller than cortex-m33, which includes all of armv8m.main.  I'm not sure how this gets used, but it might be limiting armv8m.main to only the features and instructions available in armv8m.base.

https://github.com/llvm/llvm-project/pull/195184