[Lldb-commits] [lldb] [llvm] [AArch64][llvm] Tighten SYSP parsing; don't disassemble invalid encodings (PR #182410)

[via lldb-commits]

================
@@ -279,7 +279,13 @@ class AArch64AsmParser : public MCTargetAsmParser {
   bool tryParseNeonVectorRegister(OperandVector &Operands);
   ParseStatus tryParseVectorIndex(OperandVector &Operands);
   ParseStatus tryParseGPRSeqPair(OperandVector &Operands);
-  ParseStatus tryParseSyspXzrPair(OperandVector &Operands);
+  ParseStatus tryParseSyspPair(OperandVector &Operands);
+  ParseStatus tryParseConsecutiveGPRSeqPair(OperandVector &Operands,
+                                            std::optional<unsigned> WPairClass,
+                                            unsigned XPairClass,
+                                            bool AllowXZRPair,
+                                            StringRef FirstRegExpected,
----------------
Lukacma wrote:

FirstRegExpected, SecondRegExpected,  WPairClass  and XPairClass can be derived from AllowXZRPair value, so passing them here seems like an overkill. Also if you remove them and make AllowXZRPair a template parameter instead you can get rid of tryParseSyspPair and tryParseGPRSeqPair functions.

https://github.com/llvm/llvm-project/pull/182410